Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

White text on white background in Advanved Tile Demo #532

Open
tva-TIS opened this issue Jul 31, 2019 · 1 comment
Open

White text on white background in Advanved Tile Demo #532

tva-TIS opened this issue Jul 31, 2019 · 1 comment

Comments

@tva-TIS
Copy link

tva-TIS commented Jul 31, 2019

Minor colouring issue within TileViewDemoAdvanced in Version 4:

Problem
InfoWindow that's displayed when the markers are clicked on has invisible (white on white) text.

Reason

  1. Version 4 hasn't set AppTheme set in Android Manifest (in difference to previous version)
  2. Version 4 has set a white background to the infoWindow (Version 3 has got a grey one)

Solution

  1. Set Background Color back to something dark (TileViewDemoAdvanced.java:getInfoView)
  2. Set Text Color to Something dark (TileViewDemoAdvanced.java:getInfoView)

At first i thought setting AppTheme in the Manifest would solve the issue too, but AppTheme inherits from an Theme that's not compatible with AppCompat. And if that's changed (for example to @style/Theme.AppCompat.NoActionBar that somehow doesn't solve the issue either (maybe AppCompat Themes don't override colors/set text color to white). I've tested the other two solutions, they do the trick.

@moagrius
Copy link
Owner

moagrius commented Aug 2, 2019

Thanks, will fix next time I'm on the project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants