Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Directory path in packages file gets ignored #71

Closed
dhoer opened this issue Jun 6, 2020 · 1 comment
Closed

Directory path in packages file gets ignored #71

dhoer opened this issue Jun 6, 2020 · 1 comment

Comments

@dhoer
Copy link

dhoer commented Jun 6, 2020

So requirements.txt with line colorbrewer -d /matlab:

export_fig -u http://www.mathworks.com/matlabcentral/fileexchange/23629-export-fig 
matlab2tikz -t 1.0.0
colorbrewer -d /matlab

Would get rewritten as mpm install colorbrewer -d /matlab -d /home/matlab/mpm/mpm-packages -c default:

>> mpm install -i requirements.txt
Using collection "default"
About to run the following commands: 
   mpm install export_fig -u http://www.mathworks.com/matlabcentral/fileexchange/23629-export-fig -d /home/matlab/mpm/mpm-packages -c default
   mpm install matlab2tikz -t 1.0.0 -d /home/matlab/mpm/mpm-packages -c default
   mpm install colorbrewer -d /matlab -d /home/matlab/mpm/mpm-packages -c default
Confirm (y/n)? 

Ignoring the path of /matlab/colorbrewer:

Updating paths...
   Adding to path: /home/matlab/mpm/mpm-packages/colorbrewer
@mobeets
Copy link
Owner

mobeets commented Jun 6, 2020

Yeah good find! Should be straightforward to fix. I'll just need to add some extra cases to readRequirementsFile(), to ensure that if -d is provided (or -c as well) inside requirements.txt, you cannot say something like mpm install -i requirements.txt -d example.

@mobeets mobeets closed this as completed in 4fe20f6 Jun 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants