-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publish on PhoneGap Build #20
Comments
We would be happy if it did, but we've not ever worked with the phonegap build team before (though we work a lot with the Adobe folk contributing to Apache). I think its just a matter of poking them to ask, though. |
Here is the info about creating a plugin for PhoneGap Build: If your PhoneGap plugin can already be managed by plugman, then I guess you're good to go publish it straight on the PhoneGap Build site http://build.phonegap.com/plugins#add . I'm not familiar with developping plugins, but by looking at another plugin (https://github.com/alunny/ChildBrowser) it looks like the current structure of the zip plugin, as well as the plugin.xml file, don't match the plugman specs: https://github.com/alunny/cordova-plugin-spec Changing the file structure should be straightforward. It looks like updating the plugin.xml should be quite simple too (here's a sample https://github.com/alunny/ChildBrowser/blob/master/plugin.xml ). |
Hi all |
Looks like we dont have a |
Added, let me know if thats enough. Thanks for trying to add the plugin to BGBuild for us. |
Thanks for the speedy replys! I'm guessing it doesnt like the dev in the version =p |
Hiya I've tested a fork without the "-dev" in the version now It's expecting: |
<license>Apache 2.0</license> Sorry my last post didnt have markdown |
For more information, view the plugin on https://build.phonegap.com/plugins/727 and on MobileChromeApps/cordova-plugin-zip#20
There already is a version of the org.chromium.zip plugin up on PhoneGap build. The version that was submitted was of a fork of a fork of the main zip repo and is now severely out of date. I am a contributor on https://github.com/Adobe-Marketing-Cloud/cordova-zip-plugin which the version of the plugin we use internally for some Adobe products. I was actually in the process of submitting this version of the zip plugin to PG build when I discovered someone had already submitted their copy of the fork. Anyway, I am in the process of cleaning up this issue right now with the PG team. Would the members of MobileChromeApps/zip prefer to manage the zip plugin on PG build themselves or would you rather the PG build version of the plugin point to Adobe-Marketing-Cloud/cordova-zip-plugin that we manage (eg. Adobe)? |
I think the answer is:
I'll still confirm, but having Adobe manage this in Adobe-Marketing-Cloud/cordova-zip-plugin sounds like win-win to me, especially if you are nice enough to upstream any future fixes. Thanks a bunch! |
Sounds good since we already have a need for an up-to-date zip plugin to be available on PG build. We will also take care of pushing releases when the need arises. |
How long can take this process? I need this plugin in Phonegap Build, thanks for your work |
Last 2 plugins we published took a bit less than a week, but it may depend on the tasks at hand for the PGB team. Has someone eventually already published this plugin? As @mmocny said it'd be a shame to have to fork this one just to push the publication forward. |
I have been working with PGB from the Adobe side since someone has already published a version of the zip plugin but has no interest in maintaining it. I'd like for that plugin to be removed first. I agree that having the fork doesn't make too much sense if both codebases are kept in sync. Having the fork does mean a different set of committers could manage the releases to PGB so that the MobileChromeApps org doesn't have to deal with it. I think the reason we forked the repo was to be insulated from any undesirable upstream changes to the zip plugin. /cc @Heshyo |
If I can contribute somehow to bring forward this process, please, let me know. I'm very interested on that. |
@arumsey Happy to see you taking the lead here. Thanks! Exactly as you said, a fork is unfortunate, but so would having you have to wait for us for every action. If you would like to publish this plugin under the existing name/id, we'll make sure to commit any PR to add manifests/whatever (not actually sure what the PGBuild requirements are). We trust you'll make the right call, so just let us and @corand know when its up. Thanks a bunch! |
@corand : can't you use the currently published plugin https://build.phonegap.com/plugins/727 for now ? It may be enough for you already. Hopefully in the nearby future it will point to this repository. |
@phonegapps : Thanks but I prefere this one. The one that you say, doesn't have a progress callback, and it doesn't work for me (the documentation is very poor): http://stackoverflow.com/questions/24560039/phonegap-zip-plugin-filenotfoundexception For now, I'm using this plugin, but my app doesn't have support for ios. And I really need it. |
I'm hoping to have this issue resolved very soon. I'll keep you posted. |
We're also stuck on a PB issue with this plugin, is there an ETA? Close to abandoning PB for app store submission, and it sucks to not have hydration... |
Any progress on that? Thanks |
Ok, someone has forked this repository and it is already in Phonegap Build. I will try it later. |
Ok, now this is even getting more messed up. Believe or not I have been trying to resolve this issue for several months now. The problem lies with PG build and it isn't very easy to just replace a plugin that has the same id with a plugin from a different repo. Originally the org.chromium.zip plugin was added from a fork of a fork. https://build.phonegap.com/plugins/727 Now someone else has created another fork and changed the id of the plugin in order to solve their needs. I'd very like to see this resolved as well since we have tools at Adobe that integrate with PG Build and rely on the zip plugin (which is why we created our own fork of the repo as well). Anyway, I have been told by the PG Build team at Adobe that an upcoming release will solve the issues I've been facing in trying to change the repo PG build uses for the org.chromium.zip plugin. I'm sorry it hasn't been resolved yet but am crossing my fingers it wont be too much longer. Hang in there! |
That was fast. The org.chromium.zip plugin has been removed. I'll work on getting a new version added now. |
An updated ZIP plugin is now up on PhoneGap build. https://build.phonegap.com/plugins/1188
I've also submitted 2.1.0 which should be available soon.
Going forward, as new zip plugins are released from MobileChromeApps we'll make sure to get them pushed to PG build in a timely fashion while still ensuring none of our dependencies are broken. |
That's great news, thanks. |
What's the latest available Phonegap Build version? We're using 1.2.0 and it's causing this error (with the new File plugin). I believe just the naming needs to be updated (to org.apache.cordova.file.ProgressEvent)
|
Ah never mind, found it: |
It would be convenient to be able to use the plugin through PhoneGap Build.
https://build.phonegap.com/plugins/add
The text was updated successfully, but these errors were encountered: