Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish on PhoneGap Build #20

Closed
Heshyo opened this issue Mar 25, 2014 · 28 comments
Closed

Publish on PhoneGap Build #20

Heshyo opened this issue Mar 25, 2014 · 28 comments

Comments

@Heshyo
Copy link

Heshyo commented Mar 25, 2014

It would be convenient to be able to use the plugin through PhoneGap Build.
https://build.phonegap.com/plugins/add

@mmocny
Copy link
Member

mmocny commented Mar 25, 2014

We would be happy if it did, but we've not ever worked with the phonegap build team before (though we work a lot with the Adobe folk contributing to Apache).

I think its just a matter of poking them to ask, though.

@Heshyo
Copy link
Author

Heshyo commented Mar 26, 2014

Here is the info about creating a plugin for PhoneGap Build:
http://docs.build.phonegap.com/en_US/3.3.0/developer_contributing_plugins.md.html#Contributing%20Plugins

If your PhoneGap plugin can already be managed by plugman, then I guess you're good to go publish it straight on the PhoneGap Build site http://build.phonegap.com/plugins#add .

I'm not familiar with developping plugins, but by looking at another plugin (https://github.com/alunny/ChildBrowser) it looks like the current structure of the zip plugin, as well as the plugin.xml file, don't match the plugman specs: https://github.com/alunny/cordova-plugin-spec

Changing the file structure should be straightforward. It looks like updating the plugin.xml should be quite simple too (here's a sample https://github.com/alunny/ChildBrowser/blob/master/plugin.xml ).

@cybercorey
Copy link

Hi all
I've tried to add this to the plugin manager on phonegap but keep get this error
"Plugin.xml has no description element"
I'm guessing the plugin.xml isnt correct to their standard.

@mmocny
Copy link
Member

mmocny commented Apr 14, 2014

Looks like we dont have a <description> which is silly and easy to fix :) Will fix asap.

mmocny added a commit that referenced this issue Apr 14, 2014
@mmocny
Copy link
Member

mmocny commented Apr 14, 2014

Added, let me know if thats enough. Thanks for trying to add the plugin to BGBuild for us.

@cybercorey
Copy link

Thanks for the speedy replys!
I'm now getting this error: Plugin.xml has invalid version. Must be a valid version eg. 1, 1.2 or 1.2.3

I'm guessing it doesnt like the dev in the version =p

@cybercorey
Copy link

Hiya I've tested a fork without the "-dev" in the version now It's expecting:
Apache 2.0
"Your plugin must be licensed under the MIT or Apache 2.0 license as specified in your plugin.xml."
I'm not going to go ahead and try change this on my fork as it looks like you have a licence already.

@cybercorey
Copy link

<license>Apache 2.0</license>

Sorry my last post didnt have markdown

jondoesntgit added a commit to jondoesntgit/MENA-Shelf that referenced this issue Jun 10, 2014
@arumsey
Copy link

arumsey commented Jun 19, 2014

There already is a version of the org.chromium.zip plugin up on PhoneGap build. The version that was submitted was of a fork of a fork of the main zip repo and is now severely out of date.

I am a contributor on https://github.com/Adobe-Marketing-Cloud/cordova-zip-plugin which the version of the plugin we use internally for some Adobe products. I was actually in the process of submitting this version of the zip plugin to PG build when I discovered someone had already submitted their copy of the fork.

Anyway, I am in the process of cleaning up this issue right now with the PG team.

Would the members of MobileChromeApps/zip prefer to manage the zip plugin on PG build themselves or would you rather the PG build version of the plugin point to Adobe-Marketing-Cloud/cordova-zip-plugin that we manage (eg. Adobe)?

@mmocny
Copy link
Member

mmocny commented Jun 19, 2014

I think the answer is:

  1. We would like to help make the version up on PGBuild be as up to date as possible, and random forks sound like they get in the way of that, however..
  2. We would rather do as little work as necessary since PGBuilt isn't at this point yet an active priority for us -- and so we trust Adobe-Marketing more than ourselves to keep on top of this.

I'll still confirm, but having Adobe manage this in Adobe-Marketing-Cloud/cordova-zip-plugin sounds like win-win to me, especially if you are nice enough to upstream any future fixes. Thanks a bunch!

@arumsey
Copy link

arumsey commented Jun 19, 2014

Sounds good since we already have a need for an up-to-date zip plugin to be available on PG build. We will also take care of pushing releases when the need arises.

@corand
Copy link

corand commented Jul 4, 2014

How long can take this process? I need this plugin in Phonegap Build, thanks for your work

@Heshyo
Copy link
Author

Heshyo commented Jul 5, 2014

Last 2 plugins we published took a bit less than a week, but it may depend on the tasks at hand for the PGB team.

Has someone eventually already published this plugin? As @mmocny said it'd be a shame to have to fork this one just to push the publication forward.

@arumsey
Copy link

arumsey commented Jul 7, 2014

I have been working with PGB from the Adobe side since someone has already published a version of the zip plugin but has no interest in maintaining it. I'd like for that plugin to be removed first. I agree that having the fork doesn't make too much sense if both codebases are kept in sync. Having the fork does mean a different set of committers could manage the releases to PGB so that the MobileChromeApps org doesn't have to deal with it. I think the reason we forked the repo was to be insulated from any undesirable upstream changes to the zip plugin.

/cc @Heshyo

@corand
Copy link

corand commented Jul 7, 2014

If I can contribute somehow to bring forward this process, please, let me know. I'm very interested on that.

@mmocny
Copy link
Member

mmocny commented Jul 7, 2014

@arumsey Happy to see you taking the lead here. Thanks!

Exactly as you said, a fork is unfortunate, but so would having you have to wait for us for every action. If you would like to publish this plugin under the existing name/id, we'll make sure to commit any PR to add manifests/whatever (not actually sure what the PGBuild requirements are). We trust you'll make the right call, so just let us and @corand know when its up.

Thanks a bunch!

@phonegapps
Copy link

@corand : can't you use the currently published plugin https://build.phonegap.com/plugins/727 for now ? It may be enough for you already. Hopefully in the nearby future it will point to this repository.

@corand
Copy link

corand commented Jul 8, 2014

@phonegapps : Thanks but I prefere this one. The one that you say, doesn't have a progress callback, and it doesn't work for me (the documentation is very poor): http://stackoverflow.com/questions/24560039/phonegap-zip-plugin-filenotfoundexception

For now, I'm using this plugin, but my app doesn't have support for ios. And I really need it.

@arumsey
Copy link

arumsey commented Jul 8, 2014

I'm hoping to have this issue resolved very soon. I'll keep you posted.

@DelaneyM
Copy link

We're also stuck on a PB issue with this plugin, is there an ETA? Close to abandoning PB for app store submission, and it sucks to not have hydration...

@corand
Copy link

corand commented Aug 25, 2014

Any progress on that?

Thanks

@corand
Copy link

corand commented Oct 1, 2014

Ok, someone has forked this repository and it is already in Phonegap Build. I will try it later.

https://build.phonegap.com/plugins/1071

@arumsey
Copy link

arumsey commented Oct 1, 2014

Ok, now this is even getting more messed up. Believe or not I have been trying to resolve this issue for several months now. The problem lies with PG build and it isn't very easy to just replace a plugin that has the same id with a plugin from a different repo.

Originally the org.chromium.zip plugin was added from a fork of a fork. https://build.phonegap.com/plugins/727

Now someone else has created another fork and changed the id of the plugin in order to solve their needs.

I'd very like to see this resolved as well since we have tools at Adobe that integrate with PG Build and rely on the zip plugin (which is why we created our own fork of the repo as well).

Anyway, I have been told by the PG Build team at Adobe that an upcoming release will solve the issues I've been facing in trying to change the repo PG build uses for the org.chromium.zip plugin.

I'm sorry it hasn't been resolved yet but am crossing my fingers it wont be too much longer. Hang in there!

@arumsey
Copy link

arumsey commented Oct 1, 2014

That was fast. The org.chromium.zip plugin has been removed. I'll work on getting a new version added now.

arumsey pushed a commit to Adobe-Marketing-Cloud/cordova-zip-plugin that referenced this issue Oct 1, 2014
@arumsey
Copy link

arumsey commented Oct 1, 2014

An updated ZIP plugin is now up on PhoneGap build.

https://build.phonegap.com/plugins/1188

<gap:plugin name="org.chromium.zip" version="2.0.0" />

I've also submitted 2.1.0 which should be available soon.

<gap:plugin name="org.chromium.zip" version="2.1.0" />

Going forward, as new zip plugins are released from MobileChromeApps we'll make sure to get them pushed to PG build in a timely fashion while still ensuring none of our dependencies are broken.

@Heshyo
Copy link
Author

Heshyo commented Oct 2, 2014

That's great news, thanks.

@Heshyo Heshyo closed this as completed Oct 2, 2014
@aymanar
Copy link

aymanar commented Sep 20, 2016

What's the latest available Phonegap Build version? We're using 1.2.0 and it's causing this error (with the new File plugin). I believe just the naming needs to be updated (to org.apache.cordova.file.ProgressEvent)

Uncaught module cordova-plugin-file.ProgressEvent not found

@aymanar
Copy link

aymanar commented Sep 20, 2016

Ah never mind, found it:
<gap:plugin name="cordova-plugin-zip" version="3.1.0" source="npm"/>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants