Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SimpleInterval not defined when Cython is not compiled. #32

Closed
lukasz-migas opened this issue May 23, 2024 · 2 comments
Closed

SimpleInterval not defined when Cython is not compiled. #32

lukasz-migas opened this issue May 23, 2024 · 2 comments

Comments

@lukasz-migas
Copy link

Hi,

I noticed that when importing from ms_deisotope.peak_dependency_network.intervals import SimpleInterval when the Cython module was not built (therefore the ._c.... interface is not available, the SimpleInterval is not defined.

This will lead to ImportError when importing e.g. from ms_deisotope import deconvolute_peaks.

I would be happy to make a PR to fix the issue.

@mobiusklein
Copy link
Owner

It was simple to fix and I had to put together a new release shortly in any case. It is now part of v0.0.54, published on PyPI.

I admit that I'd effectively ignored how the library behaves without the C extensions at this point since the automated release process generated pre-built wheels for most platforms now. Was this a scenario where the wheel wasn't available or was it a non-CPython runtime you were using?

@lukasz-migas
Copy link
Author

Thanks for a swift action!

I usually don't use the pure Python code either but in this case the pre-built binaries were not available (Windows, python 3.11.9).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants