This repository has been archived by the owner on Dec 31, 2020. It is now read-only.
Add support for Mobx enforceActions configuration #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielkcz
suggested changes
Jun 13, 2019
Simplify tests, remove unnecessary mocking of console, add new mobx test utils.
danielkcz
approved these changes
Jun 13, 2019
…perty updates for each Mobx enforceAction setting.
|
@FredyC I added a bit of code to each test to ensure that updates to the observables also succeed in each |
danielkcz
approved these changes
Jun 14, 2019
|
Hi! I would appreciate if you could update this branch to current master, so it could be merged. It totally prevents from using useLocalStore. I forked this branch and updated to current master without any issues. I can create another updated pull request, but I see no point, as you did the job and the only thing missing - it's outdated. |
|
Thanks for the update and merge @FredyC! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #170. Wraps observable field assignments with
runInAction()to work inenforceActions: 'always'mode (andnever/observed).