Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update api.md #2828

Merged
merged 1 commit into from
Feb 25, 2021
Merged

Update api.md #2828

merged 1 commit into from
Feb 25, 2021

Conversation

davidcim
Copy link
Contributor

It seems that these two descriptions are interchanged.

Code change checklist

  • Added/updated unit tests
  • Updated /docs. For new functionality, at least API.md should be updated
  • Verified that there is no significant performance drop (npm run perf)

@danielkcz danielkcz requested review from urugator and removed request for danielkcz February 25, 2021 09:29
urugator
urugator approved these changes Feb 25, 2021
View reviewed changes
Copy link
Collaborator

@urugator urugator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@danielkcz danielkcz merged commit d921b17 into mobxjs:main Feb 25, 2021
@iChenLei iChenLei mentioned this pull request Mar 2, 2021
Merged
This was referenced Mar 8, 2021
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@urugator urugator urugator approved these changes

Assignees
No one assigned
Labels
📖 documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@davidcim @urugator @danielkcz @iChenLei