Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build failures under load due to deadline exceeded from recordBuildHistory #3966

Open
coryb opened this issue Jun 23, 2023 · 0 comments
Open

Comments

@coryb
Copy link
Collaborator

coryb commented Jun 23, 2023

I have been trying to track down some random deadline exceeded errors from buildkit that start happening after many hours of load testing. With Go 1.21rc2 I updated all the WithTimeout to WithTimeoutCause and annotated the deadline error with the function/line it came from and found all of my deadline exceeded errors came from recordBuildHistory

DeadlineExceeded: recordBuildHistory: context deadline exceeded
1224004 v0.0.0+unknown buildkitd
github.com/moby/buildkit/solver/llbsolver.(*Solver).recordBuildHistory.func1
        /src/solver/llbsolver/solver.go:188
github.com/moby/buildkit/solver/llbsolver.(*Solver).Solve.func2
        /src/solver/llbsolver/solver.go:460
github.com/moby/buildkit/solver/llbsolver.(*Solver).Solve
        /src/solver/llbsolver/solver.go:576
github.com/moby/buildkit/control.(*Controller).Solve
        /src/control/control.go:431

This is likely related to #3743

I am wondering if we should have a shorter timeout and instead of returning the context error, just log that we failed to record build history. It doesn't seem right to return an error for the solve when the solve actually succeeds and we just failed to record it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant