executor: allow setting DNSConfig to be used by resolvconf #1040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiborvass
force-pushed
the
pass-dns-to-resolvconf
branch
from
4088599
to
ae4d8a6
Compare
|
Can you add this to the TOML config and add an integration test. Could be follow-up. |
|
@tiborvass needs rebase |
tiborvass
force-pushed
the
pass-dns-to-resolvconf
branch
from
ae4d8a6
to
af24bf6
Compare
This patch allows downstream code to pass a DNSConfig that is then used by executor/oci.GetResolvConf. This would allow the BuildKit-based builder in Docker to honor the docker daemon's DNS configuration, thus fixing a feature gap with the legacy builder. Signed-off-by: Tibor Vass <tibor@docker.com>
tiborvass
force-pushed
the
pass-dns-to-resolvconf
branch
from
af24bf6
to
8e69250
Compare
tonistiigi
approved these changes
Jun 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch allows downstream code to pass a DNSConfig that is
then used by executor/oci.GetResolvConf.
This would allow the BuildKit-based builder in Docker to honor
the docker daemon's DNS configuration, thus fixing a feature gap
with the legacy builder.
Signed-off-by: Tibor Vass tibor@docker.com