-
Notifications
You must be signed in to change notification settings - Fork 18.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Markdown syntax problems in manpages #10667
Comments
Add tests and documentation for this new feature. Signed-off-by: Arnaud Porterie <arnaud.porterie@docker.com>
ping @cpuguy83 On Mon, Feb 9, 2015 at 12:41 PM, Dan Lipsitt notifications@github.com
|
Thanks, let me take a look. |
Since this isn't fixed in docker/docker yet, I think it's appropriate that we leave this open. 😉 |
Sorry, didn't realize GH would auto-close :) |
btw, I don't like the fix I put in since it's perfectly valid to use raw html in MD, but I think it's better than not rendering anything at all. |
What happens if you use backticks to protect the params ( |
Is using Asking, because the same problem occurred on a couple of pages of the documentation as well; the values did not show up on GitHub when viewing the docs. If it is not a standard notation in man-pages, perhaps Docker should use a different convention in stead of modifying md2man, because other MarkDown renderers have the same problem. |
@thaJeztah It's pretty common when writing CLI docs to use |
can md2man be made to support < and > ? |
@duglin Can you open an issue on the repo with what you expect it to output? |
@cpuguy83 thanks for explaining.
Looking at the man-page on GitHub, the pages look mangled as well. I think the problem overall is that they use a bit of a "MarkDown-ish" syntax; everything is assumed to be " I think from that perspective, it's reasonable to not support HTML? |
Yeah, I tend to agree that this looks like a bug in our use of Markdown
here, not a bug in go-md2man.
|
Perhaps call it MarkDown-flavoured plain-text, and change the file extension to .txt, to make it better readable on GitHub as well. |
Fixes moby#10667 Signed-off-by: Brian Goff <cpuguy83@gmail.com>
Opened issue in md2man: cpuguy83/go-md2man#11 |
so what was the outcome here @cpuguy83 can you triage and add the right labels so someone can contribute it to fix it if they see this issue |
Triaged |
Closing since these man pages were updated. Thanks! |
There are errors in the manpages because parameters in angle brackets aren't included in
md2man
output. For example,renders as
Note the missing
<src>
and<dest>
.This can also be seen in GitHub's rendering of the text:
ADD [""... ""] This form is required for paths containing whitespace.
PROBLEM: man docs are often imporoperly formatted, using quotes or bolds when code blocks/segments are required
PROPOSED SOLUTION: man docs should be updated to use appropriate backticks for either inline or blocked code.
The
dockerfile.5.md
has already been gone through, but wouldn't hurt another set of eyes.The text was updated successfully, but these errors were encountered: