regression: docker logs - Cryptic error message when using log-driver=none

[dave-tucker]

docker version:

Client:
 Version:      1.9.0
 API version:  1.21
 Go version:   go1.4.3
 Git commit:   76d6bc9
 Built:        Tue Nov  3 19:20:09 UTC 2015
 OS/Arch:      linux/amd64

Server:
 Version:      1.9.0
 API version:  1.21
 Go version:   go1.4.3
 Git commit:   76d6bc9
 Built:        Tue Nov  3 19:20:09 UTC 2015
 OS/Arch:      linux/amd64

docker info:

Client:
 Version:      1.9.0
 API version:  1.21
 Go version:   go1.4.3
 Git commit:   76d6bc9
 Built:        Tue Nov  3 19:20:09 UTC 2015
 OS/Arch:      linux/amd64

Server:
 Version:      1.9.0
 API version:  1.21
 Go version:   go1.4.3
 Git commit:   76d6bc9
 Built:        Tue Nov  3 19:20:09 UTC 2015
 OS/Arch:      linux/amd64
docker@183:~$ docker info
Containers: 16
Images: 192
Server Version: 1.9.0
Storage Driver: aufs
 Root Dir: /mnt/sda1/var/lib/docker/aufs
 Backing Filesystem: extfs
 Dirs: 224
 Dirperm1 Supported: true
Execution Driver: native-0.2
Logging Driver: none
Kernel Version: 4.1.12-boot2docker
Operating System: Boot2Docker 1.9.0 (TCL 6.4); master : 16e4a2a - Tue Nov  3 19:49:22 UTC 2015
CPUs: 1
Total Memory: 996.2 MiB
Name: 183
ID: DNE3:YUNS:KRC4:BESO:PENC:Z4SU:P4RK:G5TW:HCWA:AC63:QAN2:QTML
Debug mode (server): true
 File Descriptors: 13
 Goroutines: 18
 System Time: 2015-11-06T15:55:56.715889021Z
 EventsListeners: 0
 Init SHA1:
 Init Path: /usr/local/bin/docker
 Docker Root Dir: /mnt/sda1/var/lib/docker
Labels:
 provider=virtualbox

uname -a:

Linux 183 4.1.12-boot2docker #1 SMP Tue Nov 3 06:03:36 UTC 2015 x86_64 GNU/Linux

Provide additional environment details (AWS, VirtualBox, physical, etc.):
Virtualbox using docker-machine 0.5.0

List the steps to reproduce the issue:

$ docker run --log-driver=none -d busybox top
432cb0dbaa5d211c8b36ea48e529065e40a41d3f62e94f6f114dae06c30ed662

Describe the results you received:

$ docker logs 432cb0dbaa5
Error running logs job: Failed to get logging factory: logger: no log driver named 'none' is registered

This is a pretty bad error message as it means nothing to the user.
In fact, I think this is a regression as the behaviour in 1.8.3 was different

Describe the results you expected:

Here is the result of running the same commands against 1.8.3

$ docker run --log-driver=none -d busybox top
6a7dc5904e6a1fb499b7fdd86752e512e897f78e6f0c56f84beb4fde9fae6680

$ docker logs 6a7dc5904e6a
"logs" command is supported only for "json-file" logging driver (got: none)

[dave-tucker]

I think this is definitely a regression.
1.8.3 exits with error code 1
1.9.0 exits with error code 0, even though it clearly displays an error

[dave-tucker]

Looks like the code that produced the nice error message was removed in #13707

[vdemeester]

Gonna take a look at this one this evening 😝

[LK4D4]

@vdemeester I almost finished :)

[vdemeester]

All right then 😝 👍