Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

validTagName and ValidateTagName error message inconsistent #9712

Closed
jlhawn opened this issue Dec 17, 2014 · 0 comments · Fixed by #9757
Closed

validTagName and ValidateTagName error message inconsistent #9712

jlhawn opened this issue Dec 17, 2014 · 0 comments · Fixed by #9757

Comments

@jlhawn
Copy link
Contributor

jlhawn commented Dec 17, 2014

The error message says:

https://github.com/docker/docker/blob/f0f4e42375353dc04101bb7d0f263500f4d2d046/graph/tags.go#L305
... minimum 2, maximum 30 in length.

while the regex allows a minimum of 1 and a max of 128 characters:

https://github.com/docker/docker/blob/f0f4e42375353dc04101bb7d0f263500f4d2d046/graph/tags.go#L22
^[\w][\w.-]{0,127}$
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixing ValidateTagName error message #9712
1 participant
@jlhawn