-
Notifications
You must be signed in to change notification settings - Fork 18.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite TestRunMutableNetworkFiles to avoid races #10072
Conversation
Signed-off-by: Alexander Morozov <lk4d4@docker.com>
@@ -2016,16 +2016,16 @@ func TestRunMutableNetworkFiles(t *testing.T) { | |||
t.Fatal("Content was not what was modified in the container", string(content)) | |||
} | |||
|
|||
out, _, err := runCommandWithOutput(exec.Command(dockerBinary, "run", "-d", "--name", "c2", "busybox", "sh", "-c", fmt.Sprintf("while true; do cat /etc/%s; sleep 1; done", fn))) | |||
out, _, err := runCommandWithOutput(exec.Command(dockerBinary, "run", "-d", "--name", "c2", "busybox", "top")) | |||
if err != nil { | |||
t.Fatal(err) | |||
} | |||
|
|||
contID := strings.TrimSpace(out) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need this contID
? We already named it "c2"
anyway.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, we need :/ containerStorageFile
requires id.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh right, sorry.
@icecrime @jfrazelle WDYT? |
LGTM |
1 similar comment
LGTM |
Rewrite TestRunMutableNetworkFiles to avoid races
ping @icecrime