Add backing filesystem info to docker info command where applicable

[estesp]

Fixes #9960

This adds the output of a "Backing Filesystem:" entry to docker info
to overlay, aufs, and devicemapper graphdrivers. The default list
includes a fairly complete list of common filesystem names from
linux/include/uapi/linux/magic.h, but if the backing filesystem is not
recognized, the code will simply show "<unknown>"

Docker-DCO-1.1-Signed-off-by: Phil Estes estesp@linux.vnet.ibm.com

[SvenDowideit]

pleae update the docker info example in the documentation :)

[jessfraz]

Yayyyyy you fixed my issue <3

On Thursday, January 15, 2015, Phil Estes notifications@github.com wrote:

Fixes #9960 #9960

This adds the output of a "Backing Filesystem:" entry to docker info
to overlay, aufs, and devicemapper graphdrivers. The default list
includes a fairly complete list of common filesystem names from
linux/include/uapi/linux/magic.h, but if the backing filesystem is not
recognized, the code will simply show ""

Docker-DCO-1.1-Signed-off-by: Phil Estes estesp@linux.vnet.ibm.com

javascript:_e(%7B%7D,'cvml','estesp@linux.vnet.ibm.com');

You can merge this Pull Request by running

git pull https://github.com/estesp/docker 9960-add-backingfs-info

Or view, comment on, or merge it at:

#10125
Commit Summary

• Add backing filesystem info to docker info command where applicable

File Changes

• M daemon/graphdriver/aufs/aufs.go
  https://github.com/docker/docker/pull/10125/files#diff-0 (16)
• M daemon/graphdriver/devmapper/driver.go
  https://github.com/docker/docker/pull/10125/files#diff-1 (11)
• M daemon/graphdriver/driver.go
  https://github.com/docker/docker/pull/10125/files#diff-2 (36)
• M daemon/graphdriver/overlay/overlay.go
  https://github.com/docker/docker/pull/10125/files#diff-3 (18)

Patch Links:

• https://github.com/docker/docker/pull/10125.patch
• https://github.com/docker/docker/pull/10125.diff

—
Reply to this email directly or view it on GitHub
#10125.

[estesp]

@SvenDowideit your wish is my command! :) done.. I looked for other references, but it seemed like this example in cli.md covers it..let me know if you know of any other references that need update

[SvenDowideit]

awesome :) yup, thats the only one I know of too :)

Docks LGTM - @fredlf @jamtur01

[LK4D4]

LGTM

[jessfraz]

LGTM, thanks so much for doing this, and sorry for the slow reply

[jessfraz]

I think we just need one more docs approval :)

[jamtur01]

Docs LGTM

[tianon]

I like this, but I worry about the fact that we've essentially got the exact same list duplicated twice, especially since they're not right next to each other making it more obvious that they ought to be updated in lock-step (and I think gofmt won't let them live right next to each other anyhow since one ist a const and one is a var).

Is there any simple way you can think of to reconcile this? Happy to just step back and let it ride if there's not an easy fix now, since if someone thinks of one it's easy to make a follow on PR later. 👍

[jessfraz]

can you point me to the gofmt thing?

[estesp]

yeah, I'm not sure about gofmt, but there were existing const and var sections separated by the long type definitions that I used (and the map can't be a const, so it has to be a var). I didn't move the section although I did think about the distance and wondered if anyone would care. I think it's possible to move the var section up but I don't know all the ins and outs of gofmt yet..