Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LXC needs stdin for container to remain up #10190

Merged
merged 1 commit into from
Jan 20, 2015

Conversation

ashahab-altiscale
Copy link
Contributor

To run shell(and not exit), lxc needs STDIN. Without STDIN open, it will exit 0.

Docker-DCO-1.1-Signed-off-by: Abin Shahab ashahab@altiscale.com (github: ashahab-altiscale)

To run shell(and not exit), lxc needs STDIN. Without STDIN open, it will exit 0.
Signed-off-by: Abin Shahab <ashahab@altiscale.com> (github: ashahab-altiscale)
@jessfraz
Copy link
Contributor

Can you please sign your commits following these rules:

https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work

The easiest way to do this is to amend the last commit:

git commit --amend -s --no-edit && git push -f

@ashahab-altiscale
Copy link
Contributor Author

@jfrazelle Oh I have not seen the updated format. I'll update.

@icecrime icecrime changed the title LXC NEEDS STDIN FOR CONTAINER BE UP LXC needs stdin for container to remain up Jan 19, 2015
@jessfraz
Copy link
Contributor

hmm the bot might need a better regex it looks signed, waiting on drone for the verdict

@jessfraz
Copy link
Contributor

Ya it's signed, sorry I wouldn't worry about it, ill check out my bot

@jessfraz
Copy link
Contributor

@ashahab-altiscale
Copy link
Contributor Author

So I'm guessing capitalization is also out of style? I don't want my commit comments to be YELLING at people if it's not required by the style guide :).

@tianon
Copy link
Member

tianon commented Jan 19, 2015

Haha, I'm definitely +1 to not yelling 👍

@jessfraz
Copy link
Contributor

LGTM

@ashahab-altiscale
Copy link
Contributor Author

@dineshs-altiscale

@dineshs-altiscale
Copy link
Contributor

LGTM

@ashahab-altiscale
Copy link
Contributor Author

@crosbymichael

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants