-
Notifications
You must be signed in to change notification settings - Fork 18.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LXC needs stdin for container to remain up #10190
Conversation
To run shell(and not exit), lxc needs STDIN. Without STDIN open, it will exit 0. Signed-off-by: Abin Shahab <ashahab@altiscale.com> (github: ashahab-altiscale)
Can you please sign your commits following these rules: https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work The easiest way to do this is to amend the last commit:
|
@jfrazelle Oh I have not seen the updated format. I'll update. |
hmm the bot might need a better regex it looks signed, waiting on drone for the verdict |
Ya it's signed, sorry I wouldn't worry about it, ill check out my bot |
I triggered jenkins for this here: https://jenkins.dockerproject.com/job/LXC%20PR%20Test/label=ubuntu-aufs-lxc/3/console |
So I'm guessing capitalization is also out of style? I don't want my commit comments to be YELLING at people if it's not required by the style guide :). |
Haha, I'm definitely +1 to not yelling 👍 |
LGTM |
c986a4d
to
79f17dc
Compare
LGTM |
LXC needs stdin for container to remain up
To run shell(and not exit), lxc needs STDIN. Without STDIN open, it will exit 0.
Docker-DCO-1.1-Signed-off-by: Abin Shahab ashahab@altiscale.com (github: ashahab-altiscale)