use lxc.auto.mount to ensure proc and sys are readonly #10205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set lxc.auto.mount = proc:mixed in unprivilged mode. This ensures that lxc mounts sys and proc/sysrq-trigger as readonly. Signed-off-by: Abin Shahab <ashahab@altiscale.com> (github: ashahab-altiscale) Docker-DCO-1.1-Signed-off-by: Abin Shahab <ashahab@altiscale.com> (github: ashahab-altiscale)
|
this needs documenation - and please, include any contrasts bewteen the lxc driver and the libcontainer one. |
|
I'm running this on jenkins here https://jenkins.dockerproject.com/job/LXC%20PR%20Test/label=ubuntu-aufs-lxc/4/console |
|
@ashahab-altiscale you will have to rebase now that your other PR is merged |
ashahab-altiscale
force-pushed
the
9875-non-privileged-proc-sys
branch
2 times, most recently
from
69c7526
to
d821c63
Compare
|
@SvenDowideit @dineshs-altiscale @crosbymichael rebased and documented. |
|
it's building here https://jenkins.dockerproject.com/job/LXC%20PR%20Test/label=ubuntu-aufs-lxc/4/console :) |
|
LGTM |
|
LGTM @ashahab-altiscale is having a productive week! : ) |
|
👍 ping @crosbymichael |
|
LGTM |
crosbymichael
added a commit
that referenced
this pull request
Jan 21, 2015
…proc-sys use lxc.auto.mount to ensure proc and sys are readonly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set lxc.auto.mount = proc:mixed in unprivilged mode. This ensures that lxc mounts sys and proc/sysrq-trigger as readonly.
Merge after #10190