devmapper: initialize log levels #10193
Merged
+20
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
oh go on, dare you to tell me that these magic settings are documented in your readme. :D |
|
Which magic settings? Setting DEBUG? That is a known thing and when you pass the |
vbatts
force-pushed
the
vbatts-dm_logging
branch
from
7441961
to
1794417
Compare
|
made the levels more clear. PTAL. |
| @@ -939,6 +941,11 @@ func (devices *DeviceSet) closeTransaction() error { | |||
| } | |||
|
|
|||
| func (devices *DeviceSet) initDevmapper(doInit bool) error { | |||
| if len(os.Getenv("DEBUG")) > 0 { | |||
There was a problem hiding this comment.
Actually everywhere in our code we using os.Getenv("DEBUG") != " :)
vbatts
force-pushed
the
vbatts-dm_logging
branch
from
1794417
to
9e287cb
Compare
|
@LK4D4 changed. PTAL. |
|
|
||
| // definitions from lvm2 lib/log/log.h | ||
| const ( | ||
| _ = iota |
There was a problem hiding this comment.
iota starts at 0, which we don't need. But this shows me that we need it to start at 2 and go to 7. I'll make this clearer.
Signed-off-by: Vincent Batts <vbatts@redhat.com>
Signed-off-by: Vincent Batts <vbatts@redhat.com>
vbatts
force-pushed
the
vbatts-dm_logging
branch
from
9e287cb
to
0c8be9d
Compare
|
|
||
| // definitions from lvm2 lib/log/log.h | ||
| const ( | ||
| LogLevelFatal = 2 + iota // _LOG_FATAL |
There was a problem hiding this comment.
@LK4D4 Is this clearer?
There was a problem hiding this comment.
Yup, also this is different logic as I see :) So we fixed bug!
|
LGTM |
1 similar comment
|
LGTM |
vbatts
added a commit
that referenced
this pull request
Jan 20, 2015
devmapper: initialize log levels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'll say, the importance of this change is that the skipping debug level log did the opposite of what we would want. In that when docker is run in debug mode, then no logging would occur.
Additionally, there are tell-tale output from device-mapper on WARN level 4, so this makes that the default level.
Signed-off-by: Vincent Batts vbatts@redhat.com