Zero out stats values in the cli #10251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| var ( | ||
| previousCpu uint64 | ||
| previousSystem uint64 | ||
| start = true | ||
| dec = json.NewDecoder(stream) | ||
| updates = make(chan *d, 1) |
There was a problem hiding this comment.
for a struct of a pointer and an error interface, you don't need to make it a chan of pointer, chan of struct should be enough. So make(chan d, 1).
There was a problem hiding this comment.
Google style guide proposing use pointers always if there are pointers fields.
There was a problem hiding this comment.
Yes, that is the advice i follow
crosbymichael
force-pushed
the
stats-zero
branch
from
b0850fd
to
887ecce
Compare
Based on some feedback, when you have a container via the cli that you are monitoring for stats, if you stop the container it will stay in the display but report the last datapoint that was received. This PR changes the display to zero out the values for containers where an update has not been received within a specified duration, i.e. 2 seconds. This signals the user that the container has stopped as it reports cpu and memory usage of 0. Signed-off-by: Michael Crosby <crosbymichael@gmail.com>
crosbymichael
force-pushed
the
stats-zero
branch
from
887ecce
to
bbc3849
Compare
|
LGTM |
|
LGTM |
jessfraz
pushed a commit
that referenced
this pull request
Jan 22, 2015
Zero out stats values in the cli
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on some feedback, when you have a container via the cli that you
are monitoring for stats, if you stop the container it will stay in the
display but report the last datapoint that was received.
This PR changes the display to zero out the values for containers where
an update has not been received within a specified duration, i.e. 2
seconds. This signals the user that the container has stopped as it
reports cpu and memory usage of 0.
Signed-off-by: Michael Crosby crosbymichael@gmail.com