Make version check return 400 instead of 404

[duglin]

Because 404 is just wrong

Closes: #13321

Signed-off-by: Doug Davis dug@us.ibm.com

[estesp]

This looks right-- we don't talk about version mismatch in the docs, so it is not defined right now, but 400 makes way more sense than 404. Do we need a note on version mismatch in the API docs?

code: LGTM

[duglin]

docs update wouldn't hurt. Let me see if I can find a good spot for that.

[thaJeztah]

@duglin also needs a note in the "what's new" section of the API

[runcom]

+1 and code LGTM

[thaJeztah]

thinking of that (and now it becomes complicated); is this to be considered a "breaking change"? If so; should this only be changed for API >= 1.19?

[duglin]

@thaJeztah since we're talking about an existing error condition here, and just producing a more appropriate message, I'm leaning towards thinking we don't need to worry about breaking people. But if other maintainers feel strongly about it I can add the if-stmt.

[duglin]

ok - added some doc updates.

[duglin]

ping @LK4D4

[LK4D4]

LGTM

[thaJeztah]

@LK4D4 docs review? 😉

(No worries, I think it's fine :))

[duglin]

ping @moxiegirl @fredlf if you guys see anything wrong with the docs please let me know and I'll open a new PR to fix it.

[moxiegirl]

@duglin Looks good to me Doug.

[duglin]

@moxiegirl great- thanks for checking