Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

graph: do not error out if images can't be restored #17695

Merged
merged 1 commit into from
Nov 4, 2015

Conversation

runcom
Copy link
Member

@runcom runcom commented Nov 4, 2015

Fix #17688

Signed-off-by: Antonio Murdaca runcom@redhat.com

@runcom
Copy link
Member Author

runcom commented Nov 4, 2015

ping @calavera @tiborvass

@calavera
Copy link
Contributor

calavera commented Nov 4, 2015

LGTM, it looks like we're having more cases where we want to ignore those images. Should we say something like: ignoring image, it could not be restored?

@runcom
Copy link
Member Author

runcom commented Nov 4, 2015

I'm ok with ignoring image %s, it could not be restored

Signed-off-by: Antonio Murdaca <runcom@redhat.com>
@runcom
Copy link
Member Author

runcom commented Nov 4, 2015

edited but I kept logging the error (just in case)

@tiborvass
Copy link
Contributor

LGTM

calavera added a commit that referenced this pull request Nov 4, 2015
graph: do not error out if images can't be restored
@calavera calavera merged commit 0cdc96c into moby:master Nov 4, 2015
@runcom runcom deleted the restore-images-log branch November 5, 2015 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants