Vendor libnetwork v0.7.0-dev.7 : Experimental MacVlan and IPVlan network drivers

[mavenugo]

This awesome contribution comes from @nerdalert via moby/libnetwork#964.
This PR also includes the required documentation to get up & running with these drivers.

Thanks to the CNM APIs, this is purely new driver additions and no changes to the libnetwork core or engine core.

We decided to accept it as experimental to get user feedback and make any improvements.

Note : Though some of the distros backported IPVlan drivers on the 3.19 kernel, it is extremely buggy (like this one : https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1475434) and we decided to keep the base support for IPVlan driver as 4.2.
MacVlan driver is fairly stable from 3.9,

[cpuguy83]

I think the docs for ipvlan and macvlan should go into /experimental instead of the main docs until we move this over to stable.

[cpuguy83]

but what? (should say something like support for earlier kernels exists but is buggy)

[thaJeztah]

Documentation failure looks genuine;

frontmatter: (engine/userguide/networking/vlan-networks.md) Unexpected non-whitespace char: # Macvlan and Ipvlan Docker Network Drivers

[thaJeztah]

Possibly a tab instead of a space somewhere?

[thaJeztah]

oh, and optimized versions of those images (saved off 41% of the file size);
21122-images.zip

[cpuguy83]

Just the couple of issues.

[mavenugo]

@cpuguy83 @thaJeztah we resolved the comments. PTAL.

[thaJeztah]

Ping @calavera @tiborvass if you have some time to review as well, hopefully we can get this merged soon, as it's needed for other changes coming up

[icecrime]

Very cool, and strictly adding (experimental) drivers to libnetwork, so LGTM! 🎉

[cpuguy83]

Tested out these drivers. Really awesome! We should iterate on some of the options/when to error out etc. But I'm good with this as is for experimental.

LGTM.

[cpuguy83]

I see we've still got docs in the user guide, so I'll defer to the docs team for this.
Usually with experimental we don't add them to the main docs.. but again will defer to docs team.

[cpuguy83]

ping @thaJeztah

[mavenugo]

The docs currently is not linked anywhere. This is added purely as an user-guide for folks to give it a try directly from the docker/docker master repo and not from docs.docker.com.

[thaJeztah]

Away from home right now, but feel free to merge, I can have a look at docs after that and fix up later; I know this PR is important, so don't let me uphold it

On 13 Mar 2016, at 19:13, Madhu Venugopal notifications@github.com wrote:

The docs currently is not linked anywhere. This is added purely as an user-guide for folks to give it a try directly from the docker/docker master repo and not from docs.docker.com.

—
Reply to this email directly or view it on GitHub.

[LK4D4]

@thaJeztah Yeah, let's merge and try. Sounds like exciting stuff.

[mavenugo]

Thanks @cpuguy83 @icecrime @LK4D4 @thaJeztah

With the addition of these 2 new drivers, Ops have complete control over the docker networking stack including seamless underlay plumbing.

Thanks @nerdalert for the contribution.