Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't remove TABs that are inside the command #2316

Closed

Conversation

SvenDowideit
Copy link
Contributor

only remove those that are at the beginning, end and separator

(Closes #2315) due to #522 (i think)

@SvenDowideit
Copy link
Contributor Author

ok, so when I forced everything to run with my newly build docker bundle, this breaks. so going back to learning :)

@SvenDowideit
Copy link
Contributor Author

and the above commit then breaks further code that assumes tabs have been replaced using spaces, notably

Step 11 : RUN cd /goroot/src && ./make.bash
 ---> Using cache
 ---> 635840d198e5
Step 12 : ENV GOROOT    /goroot
Error build: Invalid ENV format
Invalid ENV format

which again, should not be done to all tabs :/

clearly, all this gets better once we have a real parser for Dockerfiles #2266, #2225 , #2105

@SvenDowideit
Copy link
Contributor Author

#2266 should resolve these issues

@shykes
Copy link
Contributor

shykes commented Nov 11, 2013

@SvenDowideit do you still want us to review this?

@SvenDowideit
Copy link
Contributor Author

@shykes I guess not, I assume that #2225 will get merged eventually

@SvenDowideit SvenDowideit deleted the 2315-keep-run-cmd-tabs branch April 26, 2015 23:30
cpuguy83 pushed a commit to cpuguy83/docker that referenced this pull request May 25, 2021
cpuguy83 pushed a commit to cpuguy83/docker that referenced this pull request May 25, 2021
The roadmap document was outdated, and removed in moby#2316, so remove the link from here

Signed-off-by: Arko Dasgupta <arko.dasgupta@docker.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dockerfiles replace tabs in RUN on build
2 participants