Add missing API docs for HostConfig.PidMode #24519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `--pid` flag was added in Docker 1.5.0, but the API changes were not documented. In Docker 1.12.0, `--pid=container:<name|id>` was added as an additional option, but also undocumented. This adds the missing API documentation for this option. Also see commits 47e3da8 (for 1.5.0), and ebeb5a0 (for 1.12.0). Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
|
LGTM 🐯 |
|
author LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
--pidflag was added in Docker 1.5.0, but theAPI changes were not documented. In Docker 1.12.0,
--pid=container:<name|id>was added as an additionaloption, but also undocumented.
This adds the missing API documentation for this
option.
Also see commits
47e3da8 (for 1.5.0), and
ebeb5a0 (for 1.12.0).
Fixes #24517
relates to #10080, and #22481