Remove join-tokens from /info API #25134
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
join-tokens are not needed for this endpoint, and should not be returned. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
|
Design LGTM No opinion on whether this is needed for 1.12. |
tiborvass
added
status/2-code-review
status/needs-vendoring
and removed
status/1-design-review
status/needs-vendoring
labels
|
We'll move this to 1.13 |
|
Ugh... breaking API change after 1 release? |
|
@cpuguy83: I'm carrying this for 1.12.0. |
|
Closing in favor of #25145. |
|
@aaronlehmann @thaJeztah actually this could be reopened once #25145 is merged, to have it merged to master. |
|
Well, id needs to be updated to match @aaronlehmann's changes, so perhaps just a cherry-pick back to master |
tiborvass
added a commit
that referenced
this pull request
Jul 27, 2016
Carry #25134: Remove join-tokens from the /info API
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
join-tokens are not needed for this endpoint, and should not be as part of /info
per #24492 (comment)
ping @tiborvass if you still think this (or a better approach) is needed for 1.12, but feel free to close if not