Carry #25134: Remove join-tokens from the /info API #25145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
join-tokens are not needed for this endpoint, and should not be as part of /info Signed-off-by: Aaron Lehmann <aaron.lehmann@docker.com>
|
Note that this is opened against bump_v1.12.0, so it MUST be cherry-picked to master. I was asked to open the PR this way, but I'm not sure who's responsible for taking care of this. In general, I think it's much better to be consistent about the workflow for getting PRs into releases. If changes can flow in both directions, it's very easy to make mistakes. |
aaronlehmann
added
status/2-code-review
process/merge-to-master
and removed
status/0-triage
labels
|
LGTM, thanks! |
|
LGTM 👼 |
|
LGTM |
|
LGTM |
|
@aaronlehmann EDIT: a node that was in maintenance was enabled, it was supposed to have Go upgraded to 1.6. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
join-tokens are not needed for this endpoint, and should not be as part of /info
per #24492 (comment)