Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert docker and dockerd commands to spf13/cobra #25354

Merged
merged 7 commits into from
Aug 25, 2016
Merged

Convert docker and dockerd commands to spf13/cobra #25354

merged 7 commits into from
Aug 25, 2016

Commits on Aug 25, 2016

  1. Update spf13/cobra vendor to v1.4.1 

    Support command traversal

Signed-off-by: Daniel Nephin <dnephin@docker.com>
    @dnephin
    dnephin committed Aug 25, 2016
    Configuration menu
    Copy the full SHA
    ac40179 View commit details
    Browse the repository at this point in the history

  2. Convert dockerd to use cobra and pflag 

    Signed-off-by: Daniel Nephin <dnephin@docker.com>
    @dnephin
    dnephin committed Aug 25, 2016
    Configuration menu
    Copy the full SHA
    fb83394 View commit details
    Browse the repository at this point in the history

  3. Convert docker root command to use pflag and cobra 

    Fix the daemon proxy for cobra commands.

Signed-off-by: Daniel Nephin <dnephin@docker.com>
    @dnephin
    dnephin committed Aug 25, 2016
    Configuration menu
    Copy the full SHA
    0452ff5 View commit details
    Browse the repository at this point in the history

  4. Add testutil/tempfile 

    Improve error messages raised by assert.

Signed-off-by: Daniel Nephin <dnephin@docker.com>
    @dnephin
    dnephin committed Aug 25, 2016
    Configuration menu
    Copy the full SHA
    7c55684 View commit details
    Browse the repository at this point in the history

  5. Update unit tests for new cobra root command. 

    Cleanup cobra integration
Update windows files for cobra and pflags
Cleanup SetupRootcmd, and remove unnecessary SetFlagErrorFunc.
Use cobra command traversal

Signed-off-by: Daniel Nephin <dnephin@docker.com>
    @dnephin
    dnephin committed Aug 25, 2016
    Configuration menu
    Copy the full SHA
    31bf9ca View commit details
    Browse the repository at this point in the history

  6. Remove old cli framework. 

    Also consolidate the leftover packages under cli.
Remove pkg/mflag.
Make manpage generation work with new cobra layout.
Remove remaining mflag and fix tests after rebase with master.

Signed-off-by: Daniel Nephin <dnephin@docker.com>
    @dnephin
    dnephin committed Aug 25, 2016
    Configuration menu
    Copy the full SHA
    14712f9 View commit details
    Browse the repository at this point in the history

  7. Fix tests and windows service. 

    Support args to RunCommand
Fix docker help text test.
Fix for ipv6 tests.
Fix TLSverify option.
Fix TestDaemonDiscoveryBackendConfigReload
Use tempfile for another test.
Restore missing flag.
Fix tests for removal of shlex.

Signed-off-by: Daniel Nephin <dnephin@docker.com>
    @dnephin
    dnephin committed Aug 25, 2016
    Configuration menu
    Copy the full SHA
    6e7405e View commit details
    Browse the repository at this point in the history