Remove gccgo support #25978
Remove gccgo support #25978
Conversation
Since Go 1.7, s390x uses upstream Go, so we have no reason to support gccgo any more. Signed-off-by: Justin Cormack <justin.cormack@docker.com>
|
This is going to fail on gccgo CI! |
|
The Z failure is unrelated but @michael-holzheu have you seen this before? https://jenkins.dockerproject.org/job/Docker-PRs-z/10/console (might rebuild and see if intermittent). |
|
Hmm, seems intermittent. |
|
LGTM |
|
@justincormack z failure is a known issue in go with time.Now() rounding incorrectly on some architectures #24805 |
Interesting: DockerSwarmSuite.TestApiSwarmLeaveOnPendingJoin never failed on s390x (at least the last 218 runs with gccgo and the first 10 runs with golang 1.7). |
|
@tophj-ibm @michael-holzheu it is being fixed upstream here https://go-review.googlesource.com/#/c/27710/ |
| @@ -34,13 +34,9 @@ bundle_test_unit() { | |||
| | grep -v github.com/docker/docker/vendor \ | |||
| | grep -v github.com/docker/docker/man \ | |||
| | grep -v github.com/docker/docker/integration-cli) | |||
| go test $COVER $GCCGOFLAGS -ldflags "$LDFLAGS" "${BUILDFLAGS[@]}" $TESTFLAGS $pkg_list | |||
| go test $COVER -ldflags "$LDFLAGS" "${BUILDFLAGS[@]}" $TESTFLAGS $pkg_list | |||
There was a problem hiding this comment.
Added a commit to remove the cover conditions now
Signed-off-by: Justin Cormack <justin.cormack@docker.com>
|
@LK4D4 removed the |
|
LGTM |
Since Go 1.7, s390x uses upstream Go, so we have no reason to
support gccgo any more.
Signed-off-by: Justin Cormack justin.cormack@docker.com