-
Notifications
You must be signed in to change notification settings - Fork 18.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use singular tag names in swagger.yaml #29071
Use singular tag names in swagger.yaml #29071
Conversation
This is required to make the type generation put things in the correct directory, but unfortunately makes the names in the documentation menu look a bit crap. I think the best solution would be to add a `x-display-name` extension to tags to determine how the tags show up in the menu, rather than it depend on the name of the tag. I shall do this in a follow-up PR - for now, let's fix the breakage. Fixes moby#29045 Signed-off-by: Ben Firshman <ben@firshman.co.uk>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks to resolve the issue. make swagger-gen
no longer produces the api/containers
types
LGTM
Also – /cc @dnephin |
Yes that was my first thought. I realize now that it only checks for changes in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
In moby#29071, we made the tags the correct name for generating types, at the expense of the menu in the documentation looking good. ReDoc now has support for tag display names ( Redocly/redoc#152 ), so we can assign a more human-friendly name to the menu items. Signed-off-by: Ben Firshman <ben@firshman.co.uk>
In moby#29071, we made the tags the correct name for generating types, at the expense of the menu in the documentation looking good. ReDoc now has support for tag display names ( Redocly/redoc#152 ), so we can assign a more human-friendly name to the menu items. Signed-off-by: Ben Firshman <ben@firshman.co.uk> (cherry picked from commit 0caa6c2) Signed-off-by: Victor Vieux <vieux@docker.com>
In moby#29071, we made the tags the correct name for generating types, at the expense of the menu in the documentation looking good. ReDoc now has support for tag display names ( Redocly/redoc#152 ), so we can assign a more human-friendly name to the menu items. Signed-off-by: Ben Firshman <ben@firshman.co.uk>
This is required to make the type generation put things in the
correct directory, but unfortunately makes the names in the
documentation menu look a bit crap.
I think the best solution would be to add a
x-display-name
extension to tags to determine how the tags show up in the menu,
rather than it depend on the name of the tag. I shall do this in
a follow-up PR - for now, let's fix the breakage.
Fixes #29045
Signed-off-by: Ben Firshman ben@firshman.co.uk