Include Endpoint List for Shared Endpoints

[madhanrm]

Signed-off-by: Madhan Raj Mookkandy madhanm@microsoft.com

- What I did
Include endpoint Id for shared container support to be passed down to the platform
- How I did it

- How to verify it

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

[madhanrm]

Ping @msabansal @jhowardmsft

[madhanrm]

ping @mavenugo

[cpuguy83]

Can you explain what this is for us mere mortals :)

[madhanrm]

For providing end to end networking functionality in windows, for option --net=container:, the list of endpoints of the primary or referred container has to be passed on to the platform, so that it can replicate some of the required registry keys onto the containers. For this specific work, a required registry related to Tcpip is mirrored to make sure the same DNS servers are configured on the new containers that is just created. More could be done with this information.

[lowenna]

LGTM. The docker-py failure is not related to this - see #33757

[madhanrm]

Added another error check to throw meaningful error, when trying to create a container with shared network of another container, which is running with hyperv isolation as platform doesn't support this scenario

[cpuguy83]

It doesn't seem like either of these fields need to be persisted on the container object. Can make sure the fields aren't marshaled to json?

[madhanrm]

@cpuguy83 Can you point me out where the marshaled json is used & why do you think the windows specific fields are not needed. I am just trying to understand the use case, so that we do not miss anything for windows.
@jhowardmsft Is it safe to make this change proposed by @cpuguy83

[cpuguy83]

Because these are populated only for startup (IIRC) and not generally needed across daemon restarts.

[madhanrm]

@cpuguy83 Done

[cpuguy83]

LGTM

[lowenna]

CI failures are real:

11:46:39 These files are not properly gofmt'd:
11:46:39  - container/container.go
11:46:39  - daemon/container_operations.go
11:46:39 
11:46:39 Please reformat the above files using "gofmt -s -w" and commit the result.

[lowenna]

LGTM. Moving to status 4/merge

[yongtang]

All Jenkins tests passes after windowsRS1 rerun. Merging...