Prevent a goroutine leak when healthcheck gets stopped #33781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
What about changing the channel to a buffered channel? |
|
That'd you work too, yes. But I'd like to know why we don't want to wait
here
|
|
I don't see any reason why it can't wait either (sorry for the poor comment in the code). Nothing is waiting for |
Signed-off-by: Kenfe-Mickael Laventure <mickael.laventure@gmail.com>
mlaventure
force-pushed
the
fix-healhcheck-goroutine-leak
branch
from
f504a9d
to
67297ba
Compare
|
Alright, made it a blocking wait. If we want to take it easy, we could make the channel buffered and not wait, but there's a risk that a few go routine would piles up before the context cancellation gets picked up upon. |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kenfe-Mickael Laventure mickael.laventure@gmail.com
ping @talex5 I couldn't understand why we don't want to wait for the probe to exit here, so I just put it in a go routine. However, the code is waiting if the context is cancelled a few lines below, can the same be done here?
- What I did
Prevent a go routine leak when a probe has been started and we're asked to stop healthchecks
- How I did it
Started a goroutine that will wait on the channel
- How to verify it
- Description for the changelog
Fix a case were healthcheck could leak a goroutine
- A picture of a cute animal (not mandatory but encouraged)
🐶