ServiceConfig: log errors when loading config #34691
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Log errors when the config is loaded to notify the user of any errors, for instance, when a specified mirror has an invalid URL. Signed-off-by: Valentin Rothberg <vrothberg@suse.com>
AkihiroSuda
approved these changes
Aug 31, 2017
|
wait... isn't it a duplicate of #34495 ? |
@AkihiroSuda We could also return the error here and make checks in the callers, but as we only use it for logging, I thought that's fine.
@ripcurld0 Thanks for making the link! I had a look this PR now, and would object that it's likely to make things complicated for #34319 as |
|
I got the impression that if there is an error we would like to stop daemon execution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Log errors when the config is loaded to notify the user of any errors,
for instance, when a specified mirror has an invalid URL.
Signed-off-by: Valentin Rothberg vrothberg@suse.com
- What I did / How I did it
Catch and log errors when loading the config in
newServiceConfig().- How to verify it
Start the daemon for instance with
--registry-mirrors "in@valid:url". The daemon starts successfully, but now we can see the following log:level=warning msg="error loading mirrors: invalid mirror: \"in@valid:url\" is not a valid URI"- Description for the changelog
Log errors when the config is loaded.