Explicitly add --detach to service CLI calls #35007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The behavior of service (create/update/scale) was changed in a recent PR to docker/cli. This commit serves to remedy test failures experienced when attempting to use service calls. Should not affect current behavior. Signed-off-by: Eli Uriegas <eli.uriegas@docker.com>
|
Relates to: docker/cli#525 |
|
Also related: docker-archive/docker-ce#255 (for testing purposes) |
|
LGTM |
|
@seemethere fyi we'll need to adjust the PR to not have |
Signed-off-by: Victor Vieux <victorvieux@gmail.com>
|
Thanks for making this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Eli Uriegas eli.uriegas@docker.com
- What I did
The behavior of service (create/update/
scale) was changed in a recent PRto docker/cli. This commit serves to remedy test failures experienced
when attempting to use service calls.
Should not affect current behavior.
- How I did it
- How to verify it
- Description for the changelog
--detachflags- A picture of a cute animal (not mandatory but encouraged)
