Removing unused code with a TODO that no longer needs to be done #35220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kate Heddleston <kate.heddleston@gmail.com>
dnephin
approved these changes
Oct 17, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
I was looking to fix a TODO in the code, but found that the function isn't used anywhere in the current codebase. Thus, I removed it.
- How I did it
After doing a grep of the whole codebase, found that ProcessExitCode wasn't used anywhere so I removed it.
- How to verify it
Current code tests should verify that the removal of this function is sound.
- Description for the changelog
Removing unused ProcessExitCode function.
- A picture of a cute animal (not mandatory but encouraged)
This is my dog: