New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated developer doc to explain external CLI #35681

Merged
merged 1 commit into from Dec 13, 2017

Conversation

Projects
None yet
4 participants
@javabrett
Contributor

javabrett commented Dec 2, 2017

Need some doc on the move of the CLI to docker-ce, the included/locked/static CLI and how to replace it.

@thaJeztah

Thank you @javabrett! I left some comments inline

Show outdated Hide outdated docs/contributing/set-up-dev-env.md
Show outdated Hide outdated docs/contributing/set-up-dev-env.md
@GordonTheTurtle

This comment has been minimized.

Show comment
Hide comment
@GordonTheTurtle

GordonTheTurtle Dec 5, 2017

Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:

$ git clone -b "docs-contributing-2" git@github.com:javabrett/moby.git somewhere
$ cd somewhere
$ git rebase -i HEAD~842357011432
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

GordonTheTurtle commented Dec 5, 2017

Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:

$ git clone -b "docs-contributing-2" git@github.com:javabrett/moby.git somewhere
$ cd somewhere
$ git rebase -i HEAD~842357011432
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

@GordonTheTurtle GordonTheTurtle added dco/no and removed dco/no labels Dec 5, 2017

@javabrett

This comment has been minimized.

Show comment
Hide comment
@javabrett

javabrett Dec 11, 2017

Contributor

Anything else needed for this one?

Contributor

javabrett commented Dec 11, 2017

Anything else needed for this one?

@thaJeztah

Sorry for the delay, I missed your previous comment; I left comments inline; can you also squash your commits (we don't need to preserve the review history as separate commits, just a single commit should be ok for this change) 👍

Show outdated Hide outdated docs/contributing/set-up-dev-env.md
@thaJeztah

LGTM, thanks!

@thaJeztah

This comment has been minimized.

Show comment
Hide comment
@thaJeztah
Member

thaJeztah commented Dec 12, 2017

ping @AkihiroSuda PTAL

@GordonTheTurtle GordonTheTurtle added dco/no and removed dco/no labels Dec 13, 2017

@AkihiroSuda

This comment has been minimized.

Show comment
Hide comment
@AkihiroSuda

AkihiroSuda Dec 13, 2017

Member

LGTM except typo

Member

AkihiroSuda commented Dec 13, 2017

LGTM except typo

Updated developer doc to explain included static cli and move of cli …
…moby->docker-ce.

Signed-off-by: Brett Randall <javabrett@gmail.com>

@AkihiroSuda AkihiroSuda merged commit b595858 into moby:master Dec 13, 2017

1 check passed

dco-signed All commits are signed

@javabrett javabrett deleted the javabrett:docs-contributing-2 branch Dec 13, 2017

@thaJeztah

This comment has been minimized.

Show comment
Hide comment
@thaJeztah

thaJeztah Dec 13, 2017

Member

Thanks!!

Member

thaJeztah commented Dec 13, 2017

Thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment