Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump SwarmKit to 8852e8840e30d69db0b39a4a3d6447362e17c64f #37586

Merged
merged 1 commit into from
Aug 5, 2018

Conversation

thaJeztah
Copy link
Member

Full diff: moby/swarmkit@6826639...8852e88

Relevant changes;

Relevant changes;

- swarmkit moby#2593 agent: return error when failing to apply network key
- swarmkit moby#2645 Replace deprecated grpc functions
- swarmkit moby#2720 Test if error is nil before to log it
- swarmkit moby#2712 [orchestrator] Fix task sorting
- swarmkit moby#2677 [manager/orchestrator/reaper] Fix the condition used for skipping over running tasks

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Copy link
Member

@yongtang yongtang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once janky is 💚

@codecov
Copy link

codecov bot commented Aug 5, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@75fe414). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master   #37586   +/-   ##
=========================================
  Coverage          ?   35.62%           
=========================================
  Files             ?      611           
  Lines             ?    44962           
  Branches          ?        0           
=========================================
  Hits              ?    16019           
  Misses            ?    26732           
  Partials          ?     2211

Copy link
Member

@boaz0 boaz0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@yongtang yongtang merged commit f57f260 into moby:master Aug 5, 2018
@thaJeztah thaJeztah deleted the bump_swarmkit branch August 6, 2018 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants