New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: simplify code logic #38510

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
4 participants
@ZYecho
Copy link
Contributor

ZYecho commented Jan 8, 2019

Signed-off-by: zhangyue zy675793960@yeah.net

- What I did
simplify code logic in func getSystemCPUUsage to make more readable and easy to maintain.
- How I did it

- How to verify it
wait for CI.
- Description for the changelog

simplify code logic in func getSystemCPUUsage

- A picture of a cute animal (not mandatory but encouraged)
None.

fix: simplify code logic
Signed-off-by: zhangyue <zy675793960@yeah.net>
@olljanat

This comment has been minimized.

Copy link
Contributor

olljanat commented Jan 8, 2019

CI failed to

03:11:29 === RUN   TestServiceUpdateConfigs
03:11:31 --- FAIL: TestServiceUpdateConfigs (2.06s)
03:11:31     daemon.go:296: [d54e5620ee9ac] waiting for daemon to start
03:11:31     daemon.go:328: [d54e5620ee9ac] daemon started
03:11:31     update_test.go:188: assertion failed: error is not nil: Error response from daemon: rpc error: code = Unknown desc = update out of sequence
03:11:31     daemon.go:283: [d54e5620ee9ac] exiting daemon

Which is fixed on #38499

@thaJeztah

This comment has been minimized.

Copy link
Member

thaJeztah commented Jan 9, 2019

ping @unclejack @LK4D4 PTAL 🤗 (per #13246)

@olljanat

This comment has been minimized.

Copy link
Contributor

olljanat commented Jan 9, 2019

@ZYecho plz update your real name to sign off message.

@olljanat

This comment has been minimized.

Copy link
Contributor

olljanat commented Jan 10, 2019

(reserved for my derek commands)

@codecov

This comment has been minimized.

Copy link

codecov bot commented Jan 10, 2019

Codecov Report

Merging #38510 into master will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #38510      +/-   ##
==========================================
+ Coverage   36.62%   36.64%   +0.01%     
==========================================
  Files         608      608              
  Lines       45174    45174              
==========================================
+ Hits        16545    16552       +7     
+ Misses      26340    26334       -6     
+ Partials     2289     2288       -1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment