New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: simplify code logic #38510
Merged
Merged
fix: simplify code logic #38510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zhangyue <zy675793960@yeah.net>
CI failed to
Which is fixed on #38499 |
ping @unclejack @LK4D4 PTAL 🤗 (per #13246) |
@ZYecho plz update your real name to sign off message. |
(reserved for my derek commands) |
Codecov Report
@@ Coverage Diff @@
## master #38510 +/- ##
==========================================
+ Coverage 36.62% 36.64% +0.01%
==========================================
Files 608 608
Lines 45174 45174
==========================================
+ Hits 16545 16552 +7
+ Misses 26340 26334 -6
+ Partials 2289 2288 -1 |
tonistiigi
approved these changes
Mar 21, 2019
tiborvass
approved these changes
Mar 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: zhangyue zy675793960@yeah.net
- What I did
simplify code logic in func
getSystemCPUUsage
to make more readable and easy to maintain.- How I did it
- How to verify it
wait for CI.
- Description for the changelog
simplify code logic in func
getSystemCPUUsage
- A picture of a cute animal (not mandatory but encouraged)
None.