Allow communication over internal macvlan network with config-from in swarm #39393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To allow communication over internal macvlan network with config-from in swarm: 1) network has to override it's Internal value because it's not possible to combine --internal and --config-only parameters 2) don't change default gateway for internal macvlan network 3) network must not use dummy interface but the one from --config-from network Signed-off-by: Pavel Matěja <pavel@verotel.cz>
GordonTheTurtle
added
the
dco/no
|
Please sign your commits following these rules: $ git clone -b "master" git@github.com:lemrouch/moby.git somewhere
$ cd somewhere
$ git rebase -i HEAD~842358452600
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -fAmending updates the existing PR. You DO NOT need to open a new one. |
GordonTheTurtle
added
status/0-triage
and removed
dco/no
|
@lemrouch looks like these changes are all in files that are part of a dependency that's vendored; could you open a pull request in the libnetwork repository with these changes? The upstream files can be found in https://github.com/docker/libnetwork, and after those changes are merged there, we can vendor them in this repository with a "vendor bump" pull request; similar to #39246 |
|
The code is much more buggy than expected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"fixes #39392"
- What I did
Macvlan internal network is able to interconnect containers and other systems on different nodes in VLAN.
Internal network should not change container's default gateway.
- How I did it
Macvlan is no longer using just dummy interface but the one from config-only network
- How to verify it
Create two config-only networks on two nodes and container on each node.
Containers should be able to reach each other.
- Description for the changelog
Allow communication over internal macvlan network with config-from in swarm