Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hack: fix mixed tabs/spaces for indentation #39655

Merged
merged 1 commit into from
Aug 3, 2019
Merged

hack: fix mixed tabs/spaces for indentation #39655

merged 1 commit into from
Aug 3, 2019

Conversation

thaJeztah
Copy link
Member

just some small fix-ups that I noticed when reviewing a PR

@thaJeztah
hack: fix mixed tabs/spaces for indentation
2cffe9b 
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah requested a review from tianon as a code owner August 2, 2019 15:33
@thaJeztah thaJeztah added this to In progress in Improving CI via automation Aug 2, 2019
@thaJeztah
Copy link
Member Author

PowerPC failing on; https://jenkins.dockerproject.org/job/Docker-PRs-powerpc/15136/console

15:52:08 === Errors
15:52:08 /usr/local/go/pkg/tool/linux_ppc64le/link: running gcc failed: fork/exec /usr/bin/gcc: cannot allocate memory

@andrewhsu andrewhsu mentioned this pull request Aug 2, 2019
Open
Improving CI automation moved this from In progress to Reviewer approved Aug 2, 2019
tianon
tianon approved these changes Aug 2, 2019
View reviewed changes
Copy link
Member

@tianon tianon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍

@AkihiroSuda AkihiroSuda merged commit a6aa11a into moby:master Aug 3, 2019
Improving CI automation moved this from Reviewer approved to Done Aug 3, 2019
@thaJeztah thaJeztah deleted the fix_indentation branch August 3, 2019 10:51
This was referenced Aug 19, 2019
Merged
Merged
@thaJeztah thaJeztah added this to the 20.03.0 milestone Apr 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tianon tianon tianon approved these changes

@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

Assignees
No one assigned
Labels
area/testing process/cherry-picked status/2-code-review
Projects
Improving CI
  
Done
Milestone
20.10.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@thaJeztah @tianon @AkihiroSuda @GordonTheTurtle