Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include IPv6 address of linked containers in /etc/hosts #39837

Merged
merged 1 commit into from
Oct 3, 2019

Conversation

kdomanski
Copy link
Contributor

@kdomanski kdomanski commented Aug 31, 2019

- What I did
Only the linked container IPv4 address was being added to /etc/hosts. Now, IPv6 address will also be added if available.

Partially fixes #13228

- How to verify it

docker run -d --rm --name foo1 ubuntu:bionic sleep 60
docker run --rm --name foo2 --link foo1:foo1 ubuntu:bionic cat /etc/hosts

- Description for the changelog
Linked containers will now also have their IPv6 addresses included in /etc/hosts

- A picture of a cute animal (not mandatory but encouraged)
image

Signed-off-by: Kamil Domański <kamil@domanski.co>
@crosbymichael
Copy link
Contributor

LGTM

@tonistiigi tonistiigi merged commit cd19a33 into moby:master Oct 3, 2019
@kdomanski kdomanski deleted the linked-ipv6 branch October 4, 2019 08:52
@thaJeztah thaJeztah added this to the 20.03.0 milestone Apr 2, 2020
andryyy added a commit to mailcow/mailcow-dockerized that referenced this pull request Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

/etc/hosts does not contain IPv6 addresses (of linked containers)
5 participants