Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump logrus 1.4.2, go-shellwords, mergo, flock, creack/pty, golang/gddo, gorilla/mux #40045

Merged
merged 7 commits into from Oct 7, 2019

Conversation

thaJeztah
Copy link
Member

@thaJeztah thaJeztah commented Oct 6, 2019

bump logrus v1.4.2

full diff: sirupsen/logrus@v1.4.1...v1.4.2

bump mattn/go-shellwords v1.0.6

full diff: mattn/go-shellwords@v1.0.5...v1.0.6

relevant changes:

bump github.com/imdario/mergo v0.3.8

full diff: darccio/mergo@v0.3.7...v0.3.8

includes:

bump gofrs/flock v0.7.1

full diff: gofrs/flock@v0.7.0...v0.7.1

bump creack/pty v1.1.9

full diff: creack/pty@v1.1.7...v1.1.9

adds go mod support

bump olang/gddo 72a348e765d293ed6d1ded7b699591f14d6cd921

no local code changes, just keeping up with upstream

full diff: golang/gddo@9b12a26...72a348e

bump gorilla/mux v1.7.3

full diff: full diff: gorilla/mux@v1.7.2...v1.7.3

changes included:

full diff: sirupsen/logrus@v1.4.1...v1.4.2

- sirupsen/logrus#946 Fix solaris build
- sirupsen/logrus#966 Add a checkTerminal for nacl to support running on play.golang.org
- sirupsen/logrus#969 fix build break for plan9

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
full diff: mattn/go-shellwords@v1.0.5...v1.0.6

relevant changes:

- mattn/go-shellwords#24 Add dir option for parser
- mattn/go-shellwords#26 Fix backquote in part of argument
    - fixes mattn/go-shellwords#25 Backtick "eats" all runes until isSpace
- mattn/go-shellwords#28 Fix dollar quote
    - fixes mattn/go-shellwords#27 Multi-commands inside of command substitution are throwing "invalid command line string" errors
- mattn/go-shellwords#24 Add dir option for parser
- mattn/go-shellwords#24 Add dir option for parser
- mattn/go-shellwords#24 Add dir option for parser

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
full diff: darccio/mergo@v0.3.7...v0.3.8

includes:

- darccio/mergo#112 Add strict override
    - fixes darccio/mergo#111 WithOverride should be able to check types
- darccio/mergo#106 Fix merging of interface types with concrete values
- darccio/mergo#120 should not overwrite pointers directly, instead check embedded values
    - fixes darccio/mergo#114 Embedded struct of pointer types will overwrite the whole destination struct
- darccio/mergo#125 added WithOverrideEmptySlice config flag

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
full diff: gofrs/flock@v0.7.0...v0.7.1

- gofrs/flock#34 don't mention sync.Locker in package documentation
    - fixes gofrs/flock#33 incorrect interface
- gofrs/flock#35 Fix linting issues and add goreportcard badge

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@@ -33,7 +33,7 @@ github.com/opentracing/opentracing-go 1361b9cd60be79c4c3a7fa9841b3
github.com/google/shlex 6f45313302b9c56850fc17f99e40caebce98c716
github.com/opentracing-contrib/go-stdlib b1a47cfbdd7543e70e9ef3e73d0802ad306cc1cc
github.com/mitchellh/hashstructure 2bca23e0e452137f789efbc8610126fd8b94f73b
github.com/gofrs/flock 7f43ea2e6a643ad441fc12d0ecc0d3388b300c53 # v0.7.0
github.com/gofrs/flock 392e7fae8f1b0bdbd67dad7237d23f618feb6dbb # v0.7.1
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't opened a PR in buildkit for this yet; let me know if you want me to do that @tonistiigi

@thaJeztah
Copy link
Member Author

@vdemeester ptal for the mergo bump

full diff: creack/pty@v1.1.7...v1.1.9

adds go mod support

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah changed the title Bump logrus 1.4.2, go-shellwords 1.0.6, mergo 0.3.8, flock 0.7.1 Bump logrus 1.4.2, go-shellwords 1.0.6, mergo 0.3.8, flock 0.7.1, creack/pty 1.1.9 Oct 6, 2019
no local code changes, just keeping up with upstream

full diff: golang/gddo@9b12a26...72a348e

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
full diff: gorilla/mux@ed099d4...00bdffe

changes included:

- gorilla/mux#477 Improve CORS Method Middleware
    - implements gorilla/mux#477 Make CORSMethodMiddleware actually make sense
- gorilla/mux#489 Fix nil panic in authentication middleware example

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah changed the title Bump logrus 1.4.2, go-shellwords 1.0.6, mergo 0.3.8, flock 0.7.1, creack/pty 1.1.9 Bump logrus 1.4.2, go-shellwords, mergo, flock, creack/pty, golang/gddo, gorilla/mux Oct 6, 2019
Copy link
Member

@cpuguy83 cpuguy83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🦁

@thaJeztah thaJeztah merged commit 31da04a into moby:master Oct 7, 2019
@thaJeztah thaJeztah deleted the bump_deps branch October 7, 2019 16:38
@thaJeztah thaJeztah added this to the 20.03.0 milestone Apr 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment