Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nil panic in authentication middleware example #489

Merged
merged 1 commit into from Jun 28, 2019

Conversation

fharding1
Copy link
Member

@fharding1 fharding1 commented Jun 19, 2019

Closes #488

Runnable example of issue: https://play.golang.org/p/a45X5e78c0h
Runnable example with fix: https://play.golang.org/p/zE7dBKdOjCF

@elithrar elithrar merged commit 4248f5c into gorilla:master Jun 28, 2019
1 check passed
thaJeztah added a commit to thaJeztah/docker that referenced this pull request Oct 6, 2019
full diff: gorilla/mux@ed099d4...00bdffe

changes included:

- gorilla/mux#477 Improve CORS Method Middleware
    - implements gorilla/mux#477 Make CORSMethodMiddleware actually make sense
- gorilla/mux#489 Fix nil panic in authentication middleware example

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
docker-jenkins pushed a commit to docker/docker-ce that referenced this pull request Oct 7, 2019
full diff: gorilla/mux@ed099d4...00bdffe

changes included:

- gorilla/mux#477 Improve CORS Method Middleware
    - implements gorilla/mux#477 Make CORSMethodMiddleware actually make sense
- gorilla/mux#489 Fix nil panic in authentication middleware example

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Upstream-commit: bb5650619e26cf0b79f30bafc551e5120a0643a4
Component: engine
burnMyDread pushed a commit to burnMyDread/moby that referenced this pull request Oct 21, 2019
full diff: gorilla/mux@ed099d4...00bdffe

changes included:

- gorilla/mux#477 Improve CORS Method Middleware
    - implements gorilla/mux#477 Make CORSMethodMiddleware actually make sense
- gorilla/mux#489 Fix nil panic in authentication middleware example

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: zach <Zachary.Joyner@linux.com>
thaJeztah added a commit to thaJeztah/cli that referenced this pull request Oct 23, 2019
full diff: gorilla/mux@ed099d4...00bdffe

changes included:

- gorilla/mux#477 Improve CORS Method Middleware
    - implements gorilla/mux#477 Make CORSMethodMiddleware actually make sense
- gorilla/mux#489 Fix nil panic in authentication middleware example

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
docker-jenkins pushed a commit to docker/docker-ce that referenced this pull request Dec 4, 2019
full diff: gorilla/mux@ed099d4...00bdffe

changes included:

- gorilla/mux#477 Improve CORS Method Middleware
    - implements gorilla/mux#477 Make CORSMethodMiddleware actually make sense
- gorilla/mux#489 Fix nil panic in authentication middleware example

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Upstream-commit: 4b5ecc982a441b26846c4240c30b03f940950b31
Component: cli
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"assignment to entry in nil map" in document
2 participants