Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[19.03 backport] vendor: hcsshim 9dcb42f100215f8d375b4a9265e5bba009217a85 #41192

Merged
merged 2 commits into from
Jul 10, 2020

Conversation

ameyag
Copy link
Contributor

@ameyag ameyag commented Jul 8, 2020

Cherry-pick:

  1. vendor: Microsoft/hcsshim v0.8.9 #40909
  2. Revendor hcsshim to fix image import bug #41144

Fixes #41066
- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

thaJeztah and others added 2 commits July 8, 2020 14:07
full diff: microsoft/hcsshim@v0.8.7...v0.8.9

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
(cherry picked from commit 08d3774)
Signed-off-by: Ameya Gawde <agawde@mirantis.com>
This change brings in a single new commit from Microsoft/hcsshim. The
commit fixes an issue when unpacking a Windows container layer which
could result in incorrect directory timestamps.

This manifested most significantly in an impact to startup times of
some Windows container images (such as anything based on servercore).

Signed-off-by: Kevin Parsons <kevpar@microsoft.com>
(cherry picked from commit 2865478)
Signed-off-by: Ameya Gawde <agawde@mirantis.com>
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah
Copy link
Member

@cpuguy83 PTAL

Copy link
Member

@cpuguy83 cpuguy83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all the changes.
The majority of it seems to be to add context.Context support, and then tracing/logging changes (lots of logging replaced by tracing).

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants