New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add /usage
endpoint per object type
#42560
Draft
rvolosatovs
wants to merge
10
commits into
moby:master
Choose a base branch
from
rvolosatovs:per_object_df
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rvolosatovs
force-pushed
the
per_object_df
branch
3 times, most recently
from
June 25, 2021 11:14
cd7fdb1
to
de35fde
Compare
rvolosatovs
changed the title
Add
Add Jun 25, 2021
/df
endpoint per object type/usage
endpoint per object type
rvolosatovs
force-pushed
the
per_object_df
branch
6 times, most recently
from
June 28, 2021 10:24
58a59ea
to
ceaf471
Compare
rvolosatovs
force-pushed
the
per_object_df
branch
3 times, most recently
from
July 5, 2021 11:33
2f53880
to
a2abcb3
Compare
rvolosatovs
force-pushed
the
per_object_df
branch
from
July 6, 2021 17:57
a2abcb3
to
87503b2
Compare
rvolosatovs
force-pushed
the
per_object_df
branch
from
July 15, 2021 21:29
87503b2
to
95fa207
Compare
rvolosatovs
force-pushed
the
per_object_df
branch
2 times, most recently
from
August 2, 2021 20:26
2de0c0a
to
4404a90
Compare
Signed-off-by: Roman Volosatovs <roman.volosatovs@docker.com>
Signed-off-by: Roman Volosatovs <roman.volosatovs@docker.com>
Signed-off-by: Roman Volosatovs <roman.volosatovs@docker.com>
Signed-off-by: Roman Volosatovs <roman.volosatovs@docker.com>
Signed-off-by: Roman Volosatovs <roman.volosatovs@docker.com>
Signed-off-by: Roman Volosatovs <roman.volosatovs@docker.com>
Signed-off-by: Roman Volosatovs <roman.volosatovs@docker.com>
Signed-off-by: Roman Volosatovs <roman.volosatovs@docker.com>
- Simplify existing implementation - Introduce `rangeContainers` for greater flexibility Signed-off-by: Roman Volosatovs <roman.volosatovs@docker.com>
Signed-off-by: Roman Volosatovs <roman.volosatovs@docker.com>
rvolosatovs
force-pushed
the
per_object_df
branch
from
August 4, 2021 16:03
4404a90
to
f2713e3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Add
/usage
endpoint per object type- How I did it
pkg/compute.Singleton
, which ensures computations are simultaneously performed by at most one goroutine per object type and the results are propagated to all goroutines simultaneously calling the method. (i.e. if A() is called 20 simultaneously, only do the actual work once and return the computed value to all 20 callers)- How to verify it
Call per-object methods,
Singleton
implementation is verified by unit test attached.- Description for the changelog
Per-object (container, image, volume, build) endpoints are now available
- TODO