Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

daemon/logger: refactor followLogs and replace flaky TestFollowLogsHandleDecodeErr #43105

Merged
merged 2 commits into from
Jan 12, 2022
Merged

daemon/logger: refactor followLogs and replace flaky TestFollowLogsHandleDecodeErr #43105

merged 2 commits into from
Jan 12, 2022

Commits on Dec 27, 2021

  1. daemon/logger: refactor followLogs to write more unit tests 

    followLogs() is getting really long (170+ lines) and complex.
The function has multiple inner functions that mutate its variables.

To refactor the function, this change introduces follow{} struct.
The inner functions are now defined as ordinal methods, which are
accessible from tests.

Signed-off-by: Kazuyoshi Kato <katokazu@amazon.com>
    @kzys
    kzys committed Dec 27, 2021
    Configuration menu
    Copy the full SHA
    7a10f5a View commit details
    Browse the repository at this point in the history

  2. daemon/logger: replace flaky TestFollowLogsHandleDecodeErr 

    Signed-off-by: Kazuyoshi Kato <katokazu@amazon.com>
    @kzys
    kzys committed Dec 27, 2021
    Configuration menu
    Copy the full SHA
    c91e09b View commit details
    Browse the repository at this point in the history