daemon/logger: refactor followLogs and replace flaky TestFollowLogsHandleDecodeErr #43105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
followLogs() is getting really long (170+ lines) and complex.
The function has multiple inner functions that mutate its variables.
To refactor the function, this change introduces follow{} struct.
The inner functions are now defined as ordinal methods, which are
accessible from tests.
Signed-off-by: Kazuyoshi Kato <katokazu@amazon.com>
Signed-off-by: Kazuyoshi Kato <katokazu@amazon.com>
|
Failure on windows looks like a flaky test; #38521 (I'll kick ci) |
thaJeztah
approved these changes
Jan 4, 2022
|
(added cherry-pick label, as this is a follow-up / fix for changes in #43043) |
|
@cpuguy83 ptal 🤗 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
This PR refactors followLogs and replaces flaky TestFollowLogsHandleDecodeErr by adding a small more focused test.
- How I did it
The first commit is refactoring. The second commit is removing the flaky test and adding a new one.
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)
(from https://www.bbc.co.uk/programmes/p05rkdmp)