-
Notifications
You must be signed in to change notification settings - Fork 18.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update containerd binary to v1.5.9 #43138
Conversation
😩 === FAIL: daemon/logger/loggerutils TestFollowLogsHandleDecodeErr (0.02s)
time="2022-01-10T16:10:50Z" level=error msg="Log reader notified that it must re-open log file, some log data may not be streamed to the client." file=/tmp/TestFollowLogsHandleDecodeErr3236554872
logfile_test.go:317: assertion failed: 5 (int) != 6 (dec.resetCount int) |
Yeah, there's a fix for that one, but not merged yet; #43105 |
Can we backport this to 20.10? containerd v1.4 EOL is very soon (February 3, 2022) https://github.com/containerd/containerd/blob/main/RELEASES.md#support-horizon |
Yeah, we should probably at least have a draft PR to verify it works ok |
More failures on Windows 2022 with renaming. Not related, but CI is flaky on Windows 😞
|
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
a1d8366
to
df3ea5d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
- What I did
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)