-
Notifications
You must be signed in to change notification settings - Fork 18.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Freeze the namesgenerator package against new additions #43210
Conversation
I explicitly did not include a CI check for this because I think we're still open to bug fixes, for example, just not new additions to the list, which is how I tried to word my first pass on the wording here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Overall looks good; left a suggestion to satisfy linters and for consistency
For people arriving here (I see some down votes); some further context on why we're doing this. We discussed this change in our maintainers meeting and concluded that, while we all loved the initial idea of this package, over the years this packages started to require more maintenance than desirable. To provide some examples; over the years we've had to make changes on the list because combinations of names could lead to unfortunate combinations, adjectives not suitable for all situations or having negative implications, or due people on the list becoming controversial. In addition, there are technical limitations (surnames not being unique, length of names, names being limited to ASCII, which implicitly excludes names from many regions) that complicate things. With millions of active users, spread over a wide variety of continents and cultures, It has become more and more complicated to keep the list inclusive, diverse, and balanced. We don't consider ourselves good arbitrators for this, and doing so is both time-consuming (researching the background of each and every person added) and causes a significant amount of load on maintainers (is this person good to add to the list? are there possible reasons to not include the person? is the list still balanced?). Time and resources better spent in other ways. All of the above combined led us to the decision to "freeze" the list in its current state, and to rethink future directions of this feature, which could be a list of random names+adjectives, a templating option to make names more deterministic based on properties of the container (or volume, etc.), or even a pluggable name-generator to allow users to provide their own naming schemes. I hope this helps understanding why we made this decision! 🤗 |
See the added comment/documentation within the package for more details. Signed-off-by: Tianon Gravi <admwiggin@gmail.com>
0456241
to
624b3cf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Any way to use our own custom list of words instead, so we can bypass all the PC nonsense (etc.?) (Plus it'd be cooler to have a bunch of random star wars universe names) ;) |
See the added comment/documentation within the package for more details.
We discussed this (and the problems it has caused historically) in today's maintainer meeting, and there was some consensus that starting with a freeze on the existing file is a good compromise for now.