Create directories for tar files with relaxed permissions #4440
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Docker-DCO-1.1-Signed-off-by: Alexey Kotlyarov <alexey@infoxchange.net.au> (github: koterpillar)
|
ping @creack |
|
LGTM |
|
/cc @crosbymichael |
|
LGTM |
crosbymichael
added a commit
that referenced
this pull request
Mar 10, 2014
Create directories for tar files with relaxed permissions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #4068 by recreating the AUFS directories without explicitly restricting permissions, just like the
tarcommand does by default (both will still follow the set umask value).It's still not perfect - the explicitly set directory permissions in the parent image are lost - but better than completely broken images.
P.S. As you can see,
600 != 0600.