-
Notifications
You must be signed in to change notification settings - Fork 18.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci(buildkit): match moby go version for buildkit tests #45947
Conversation
55bd8cb
to
704fe06
Compare
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
704fe06
to
ee9fe2c
Compare
@thaJeztah As discussed we still need to vendor back to BuildKit v0.11 the 23.0 branch once #45942 is merged with its 23.0 backport. |
I think these two would already be ready to go for that; |
Ah right we would need these I guess. SGTM. |
We don't need to pick to 23.0. BuildKit v0.10 is using Go 1.18. |
Ah, right, I was thinking because the 23.0 branch is using go1.20 (or go1.19), but I guess we're "fine" if CI passes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's green!
LGTM
Triggered the workflow manually on 23.0 branch to see how it goes: https://github.com/moby/moby/actions/runs/5535119683 |
23.0 branch looks good: https://github.com/moby/moby/actions/runs/5535119683 |
follow-up
related to
- What I did
BuildKit integration tests image always pulls latest Go 1.20: https://github.com/moby/buildkit/blob/ca5d5bff71976d99d3ae6bb55dae7e4dd017c22d/Dockerfile#L19
With latest Go 1.20.6 we see failed tests in buildkit workflow (#45932 (comment)) related to #45935
Let's pin go version for buildkit tests matching the one in this repo.
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)