Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(buildkit): match moby go version for buildkit tests #45947

Merged
merged 2 commits into from
Jul 12, 2023

Conversation

crazy-max
Copy link
Member

@crazy-max crazy-max commented Jul 12, 2023

follow-up

related to

- What I did

BuildKit integration tests image always pulls latest Go 1.20: https://github.com/moby/buildkit/blob/ca5d5bff71976d99d3ae6bb55dae7e4dd017c22d/Dockerfile#L19

With latest Go 1.20.6 we see failed tests in buildkit workflow (#45932 (comment)) related to #45935

Let's pin go version for buildkit tests matching the one in this repo.

- How I did it

- How to verify it

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
@crazy-max crazy-max marked this pull request as ready for review July 12, 2023 17:33
@crazy-max
Copy link
Member Author

@thaJeztah As discussed we still need to vendor back to BuildKit v0.11 the 23.0 branch once #45942 is merged with its 23.0 backport.

@thaJeztah
Copy link
Member

@crazy-max
Copy link
Member Author

I think these two would already be ready to go for that;

* [[0.11] vendor: github.com/containerd/containerd v1.6.21 buildkit#3884](https://github.com/moby/buildkit/pull/3884)

* [[0.11] Dockerfile: update runc v1.1.7, containerd v1.6.21 buildkit#3887](https://github.com/moby/buildkit/pull/3887)

Ah right we would need these I guess. SGTM.

@crazy-max
Copy link
Member Author

@thaJeztah

image

We don't need to pick to 23.0. BuildKit v0.10 is using Go 1.18.

@thaJeztah
Copy link
Member

We don't need to pick to 23.0. BuildKit v0.10 is using Go 1.18.

Ah, right, I was thinking because the 23.0 branch is using go1.20 (or go1.19), but I guess we're "fine" if CI passes

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's green!

LGTM

@crazy-max
Copy link
Member Author

We don't need to pick to 23.0. BuildKit v0.10 is using Go 1.18.

Ah, right, I was thinking because the 23.0 branch is using go1.20 (or go1.19), but I guess we're "fine" if CI passes

Triggered the workflow manually on 23.0 branch to see how it goes: https://github.com/moby/moby/actions/runs/5535119683

@crazy-max
Copy link
Member Author

We don't need to pick to 23.0. BuildKit v0.10 is using Go 1.18.

Ah, right, I was thinking because the 23.0 branch is using go1.20 (or go1.19), but I guess we're "fine" if CI passes

Triggered the workflow manually on 23.0 branch to see how it goes: https://github.com/moby/moby/actions/runs/5535119683

23.0 branch looks good: https://github.com/moby/moby/actions/runs/5535119683

image

@cpuguy83 cpuguy83 merged commit 1d0bb72 into moby:master Jul 12, 2023
102 checks passed
@crazy-max crazy-max deleted the ci-buildkit-goversion branch July 12, 2023 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants