Commits on Feb 28, 2024

1. disable pulling legacy image formats by default …

   This patch disables pulling legacy (schema1 and schema 2, version 1) images by
   default.
   
   A `DOCKER_ENABLE_DEPRECATED_PULL_SCHEMA_1_IMAGE` environment-variable is
   introduced to allow re-enabling this feature, aligning with the environment
   variable used in containerd 2.0 (`CONTAINERD_ENABLE_DEPRECATED_PULL_SCHEMA_1_IMAGE`).
   
   With this patch, attempts to pull a legacy image produces an error:
   
   With graphdrivers:
   
       docker pull docker:1.0
       1.0: Pulling from library/docker
       [DEPRECATION NOTICE] Docker Image Format v1, and Docker Image manifest version 2, schema 1 support will be removed in an upcoming release. Suggest the author of docker.io/library/docker:1.0 to upgrade the image to the OCI Format, or Docker Image manifest v2, schema 2. More information at https://docs.docker.com/go/deprecated-image-specs/
   
   With the containerd image store enabled, output is slightly different
   as it returns the error before printing the `1.0: pulling ...`:
   
       docker pull docker:1.0
       Error response from daemon: [DEPRECATION NOTICE] Docker Image Format v1 and Docker Image manifest version 2, schema 1 support is disabled by default and will be removed in an upcoming release. Suggest the author of docker.io/library/docker:1.0 to upgrade the image to the OCI Format or Docker Image manifest v2, schema 2. More information at https://docs.docker.com/go/deprecated-image-specs/
   
   Using the "distribution" endpoint to resolve the digest for an image also
   produces an error:
   
       curl -v --unix-socket /var/run/docker.sock http://foo/distribution/docker.io/library/docker:1.0/json
       *   Trying /var/run/docker.sock:0...
       * Connected to foo (/var/run/docker.sock) port 80 (#0)
       > GET /distribution/docker.io/library/docker:1.0/json HTTP/1.1
       > Host: foo
       > User-Agent: curl/7.88.1
       > Accept: */*
       >
       < HTTP/1.1 400 Bad Request
       < Api-Version: 1.45
       < Content-Type: application/json
       < Docker-Experimental: false
       < Ostype: linux
       < Server: Docker/dev (linux)
       < Date: Tue, 27 Feb 2024 16:09:42 GMT
       < Content-Length: 354
       <
       {"message":"[DEPRECATION NOTICE] Docker Image Format v1, and Docker Image manifest version 2, schema 1 support will be removed in an upcoming release. Suggest the author of docker.io/library/docker:1.0 to upgrade the image to the OCI Format, or Docker Image manifest v2, schema 2. More information at https://docs.docker.com/go/deprecated-image-specs/"}
       * Connection #0 to host foo left intact
   
   Starting the daemon with the `DOCKER_ENABLE_DEPRECATED_PULL_SCHEMA_1_IMAGE`
   env-var set to a non-empty value allows pulling the image;
   
       docker pull docker:1.0
       [DEPRECATION NOTICE] Docker Image Format v1 and Docker Image manifest version 2, schema 1 support is disabled by default and will be removed in an upcoming release. Suggest the author of docker.io/library/docker:1.0 to upgrade the image to the OCI Format or Docker Image manifest v2, schema 2. More information at https://docs.docker.com/go/deprecated-image-specs/
       b0a0e6710d13: Already exists
       d193ad713811: Already exists
       ba7268c3149b: Already exists
       c862d82a67a2: Already exists
       Digest: sha256:5e7081837926c7a40e58881bbebc52044a95a62a2ea52fb240db3fc539212fe5
       Status: Image is up to date for docker:1.0
       docker.io/library/docker:1.0
   
   Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

   

   thaJeztah committed Feb 28, 2024
   Configuration menu

   • View commit details
   • Copy full SHA for 62b33a2
   • Browse repository at this point

   Copy the full SHA

   62b33a2 View commit details

   Browse the repository at this point in the history