Fix --workdir=/ #6646
Fix --workdir=/ #6646
Conversation
|
I can't think of any, but are we sure that changing |
|
Should this check happen after we get the Abs of both the link and root? |
|
@tiborvass Also, your test doesn't test original problem described in #6619 :) I mean that it was about |
|
@LK4D4 the original problem was about running an image with workdir=/. It just happened that the reporter built the image with a Dockerfile. The problem is not Dockerfile-specific though. |
|
@crosbymichael you are right. I updated the PR. |
|
travis failed because of go fmt |
| return root, nil | ||
| } | ||
|
|
||
|
|
There was a problem hiding this comment.
I think this double space is what gofmt doesn't like.
Docker-DCO-1.1-Signed-off-by: Tibor Vass <teabee89@gmail.com> (github: tiborvass)
Docker-DCO-1.1-Signed-off-by: Tibor Vass <teabee89@gmail.com> (github: tiborvass)
|
@tianon @crosbymichael updated. |
|
LGTM @crosbymichael @LK4D4 @unclejack can you please review this ? |
|
LGTM |
moby/moby#6646 Looks like Ubuntu's Docker doesn't like the workdir being set to /.
Fixes #6619.
This fixes a bug in FollowSymlinkInScope in the case where link == root.